Port: Autogenerate #undef all macros defined in a C/asm file #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkannwischer
requested changes
Nov 10, 2025
Contributor
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Thanks @willieyz - this looks mostly good. I found one TODO that can now be removed.
willieyz
force-pushed
the
port-autogen-undef
branch
3 times, most recently
from
acfef8c to
7f3a90f
Compare
mkannwischer
approved these changes
Nov 12, 2025
Contributor
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Thanks @willieyz. LGTM.
- This commit port the following function to autogen form mlkem-native. - gen_source_undefs() - gen_undefs() - Add gen_undefs() to main() Signed-off-by: willieyz <willie.zhao@chelpis.com>
Signed-off-by: willieyz <willie.zhao@chelpis.com>
mkannwischer
force-pushed
the
port-autogen-undef
branch
from
7f3a90f to
296b384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: Autogenerate #undef all macros defined in a C/asm file #581
This PR port the following function to autogen form mlkem-native, auto generate
#undefmacros in C/asm filesgen_source_undefs()gen_undefs()gen_undefs()tomain()