Port and exercise MLD_CHECK_APIS
#670
Merged
+86
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willieyz
force-pushed
the
mld-check-apis
branch
2 times, most recently
from
2533264 to
57868e7
Compare
mkannwischer
approved these changes
Nov 12, 2025
Contributor
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
LGTM. Thanks @willieyz for porting this.
mkannwischer
force-pushed
the
mld-check-apis
branch
from
57868e7 to
abc0d03
Compare
- This commit port and exercise the `MLD_CHECK_APIS` to mldsa-native,
referencing from mlkem-native
- add the API consistency between internal sign.h and external
mldsa_native.h for forllowing:
- CRYPTO_SECRETKEYBYTES != \
MLDSA_SECRETKEYBYTES(MLD_CONFIG_API_PARAMETER_SET)
- CRYPTO_PUBLICKEYBYTES != \
MLDSA_PUBLICKEYBYTES(MLD_CONFIG_API_PARAMETER_SET)
- CRYPTO_BYTES != \
MLDSA_BYTES(MLD_CONFIG_API_PARAMETER_SET)
- This commit add consistency checking for API and conduct sanity checks
on the bakcend in common.h
Signed-off-by: willieyz <willie.zhao@chelpis.com>
mkannwischer
force-pushed
the
mld-check-apis
branch
from
abc0d03 to
26138d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #Port and exercise
MLK_CHECK_APISoption #579This PR port and exercise the
MLD_CHECK_APISto mldsa-native, referencing from mlkem-nativeAdd the API consistency between internal
sign.hand externalmldsa_native.hfor forllowing:Add consistency checking for API and conduct sanity checks on the bakcend in
common.h