From 1de90d4c58c5a948e5fd98d6e1e6bd76ea499f9d Mon Sep 17 00:00:00 2001 From: vsquared Date: Sat, 16 Nov 2024 15:59:15 -0600 Subject: [PATCH 1/4] Create vsquared-patch-1 Please add _all seven of the javafx modules so that we may use JavaFX controls in our apps. Thanks. --- vsquared-patch-1 | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 vsquared-patch-1 diff --git a/vsquared-patch-1 b/vsquared-patch-1 new file mode 100644 index 0000000000..10c3eac669 --- /dev/null +++ b/vsquared-patch-1 @@ -0,0 +1,5 @@ +In JavaBuild.java line 1086 +change this line: + "--add-modules", "javafx.base,javafx.graphics,javafx.swing", +to this: + "--add-modules", "javafx.base,javafx.graphics,javafx.swing,javafx.controls,javafx.media,javafx.web,javafx.fxml", From 461360123cf967a02829ca78955fb6d68a05187a Mon Sep 17 00:00:00 2001 From: vsquared Date: Sat, 16 Nov 2024 19:56:10 -0600 Subject: [PATCH 2/4] Add all seven of the javafx modules to JavaBuild.java Please add _all seven of the javafx modules so that we may use JavaFX controls in our apps. Thanks. --- java/src/processing/mode/java/JavaBuild.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/java/src/processing/mode/java/JavaBuild.java b/java/src/processing/mode/java/JavaBuild.java index b367e2c8f8..96b9beaefd 100644 --- a/java/src/processing/mode/java/JavaBuild.java +++ b/java/src/processing/mode/java/JavaBuild.java @@ -1083,7 +1083,9 @@ static public String[] getArgsJavaFX(String modulePath) { // Full list of modules, let's not commit to all of these unless // a compelling argument is made or a reason presents itself. //"javafx.base,javafx.controls,javafx.fxml,javafx.graphics,javafx.media,javafx.swing,javafx.web" - "--add-modules", "javafx.base,javafx.graphics,javafx.swing", + // "--add-modules", "javafx.base,javafx.graphics,javafx.swing", +// ***** change to: + "--add-modules", "javafx.base,javafx.graphics,javafx.swing,javafx.controls,javafx.media,javafx.web,javafx.fxml", // TODO Presumably, this is only because com.sun.* classes are being used? // https://github.com/processing/processing4/issues/208 From cb26c901812ca75e154604e1efbfb119eafb9127 Mon Sep 17 00:00:00 2001 From: vsquared Date: Sat, 16 Nov 2024 23:44:17 -0600 Subject: [PATCH 3/4] Delete vsquared-patch-1 --- vsquared-patch-1 | 5 ----- 1 file changed, 5 deletions(-) delete mode 100644 vsquared-patch-1 diff --git a/vsquared-patch-1 b/vsquared-patch-1 deleted file mode 100644 index 10c3eac669..0000000000 --- a/vsquared-patch-1 +++ /dev/null @@ -1,5 +0,0 @@ -In JavaBuild.java line 1086 -change this line: - "--add-modules", "javafx.base,javafx.graphics,javafx.swing", -to this: - "--add-modules", "javafx.base,javafx.graphics,javafx.swing,javafx.controls,javafx.media,javafx.web,javafx.fxml", From 7df7f28a68f20c6abd4e4fecc6b5b4dc60629efa Mon Sep 17 00:00:00 2001 From: vsquared Date: Sat, 16 Nov 2024 23:48:01 -0600 Subject: [PATCH 4/4] Add all seven of the javafx modules to JavaBuild.java Please add _all seven of the javafx modules so that we may use JavaFX controls in our apps. Thanks. --- java/src/processing/mode/java/JavaBuild.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/java/src/processing/mode/java/JavaBuild.java b/java/src/processing/mode/java/JavaBuild.java index 96b9beaefd..757954978c 100644 --- a/java/src/processing/mode/java/JavaBuild.java +++ b/java/src/processing/mode/java/JavaBuild.java @@ -1083,8 +1083,6 @@ static public String[] getArgsJavaFX(String modulePath) { // Full list of modules, let's not commit to all of these unless // a compelling argument is made or a reason presents itself. //"javafx.base,javafx.controls,javafx.fxml,javafx.graphics,javafx.media,javafx.swing,javafx.web" - // "--add-modules", "javafx.base,javafx.graphics,javafx.swing", -// ***** change to: "--add-modules", "javafx.base,javafx.graphics,javafx.swing,javafx.controls,javafx.media,javafx.web,javafx.fxml", // TODO Presumably, this is only because com.sun.* classes are being used?