From cfa070ed23cb813d829c7a535021e03d2348252a Mon Sep 17 00:00:00 2001 From: 644262163 <31299382+644262163@users.noreply.github.com> Date: Wed, 24 Apr 2019 20:58:43 +0800 Subject: [PATCH 1/7] fixing FROM rule --- sample_rules/basic_rules.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sample_rules/basic_rules.yaml b/sample_rules/basic_rules.yaml index 4690472..59aede6 100644 --- a/sample_rules/basic_rules.yaml +++ b/sample_rules/basic_rules.yaml @@ -86,7 +86,8 @@ - "#from" - label: "no_tag" - regex: /^[:]/ + regex: /:/ + inverse_rule: true level: "error" message: "No tag is used" description: "No tag is used. It is recommended that a specific tag is used in the FROM line or *-released which is the latest supported release." From f3426112ba11adc366b65d897ba750df9e87c2e1 Mon Sep 17 00:00:00 2001 From: 644262163 <31299382+644262163@users.noreply.github.com> Date: Wed, 24 Apr 2019 21:03:41 +0800 Subject: [PATCH 2/7] fixing FROM rule --- config/default_rules.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/config/default_rules.yaml b/config/default_rules.yaml index 66d2741..703f135 100644 --- a/config/default_rules.yaml +++ b/config/default_rules.yaml @@ -86,7 +86,8 @@ - "#from" - label: "no_tag" - regex: /^[:]/ + regex: /:/ + inverse_rule: true level: "error" message: "No tag is used" description: "lorem ipsum tar" From 4b6edb7b3a293f97eea961967b4c214df3d23fc2 Mon Sep 17 00:00:00 2001 From: 644262163 <31299382+644262163@users.noreply.github.com> Date: Wed, 24 Apr 2019 21:04:38 +0800 Subject: [PATCH 3/7] fixing FROM rule --- sample_rules/basic_rules_atomic.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sample_rules/basic_rules_atomic.yaml b/sample_rules/basic_rules_atomic.yaml index 41dca23..63597d7 100644 --- a/sample_rules/basic_rules_atomic.yaml +++ b/sample_rules/basic_rules_atomic.yaml @@ -86,7 +86,8 @@ - "#from" - label: "no_tag" - regex: /^[:]/ + regex: /:/ + inverse_rule: true level: "error" message: "No tag is used" description: "lorem ipsum tar" From 43577cf213551614ce67b46432a78027633eae4c Mon Sep 17 00:00:00 2001 From: 644262163 <31299382+644262163@users.noreply.github.com> Date: Wed, 24 Apr 2019 21:05:18 +0800 Subject: [PATCH 4/7] fixing FROM rule --- sample_rules/default_rules.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sample_rules/default_rules.yaml b/sample_rules/default_rules.yaml index b45d653..6ad2b6c 100644 --- a/sample_rules/default_rules.yaml +++ b/sample_rules/default_rules.yaml @@ -86,7 +86,8 @@ - "#from" - label: "no_tag" - regex: /^[:]/ + regex: /:/ + inverse_rule: true level: "error" message: "No tag is used" description: "lorem ipsum tar" From b324781c1e1d7667db3ef0661079750a4984d3da Mon Sep 17 00:00:00 2001 From: 644262163 <31299382+644262163@users.noreply.github.com> Date: Wed, 24 Apr 2019 21:07:33 +0800 Subject: [PATCH 5/7] fixing FROM rule --- sample_rules/openshift.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sample_rules/openshift.yaml b/sample_rules/openshift.yaml index 826b3e7..2592784 100644 --- a/sample_rules/openshift.yaml +++ b/sample_rules/openshift.yaml @@ -86,7 +86,8 @@ - "#from" - label: "no_tag" - regex: /^[:]/ + regex: /:/ + inverse_rule: true level: "error" message: "No tag is used" description: "lorem ipsum tar" From da3f06663ac7312254ab714a8f2e5b6e23d581f1 Mon Sep 17 00:00:00 2001 From: 644262163 <31299382+644262163@users.noreply.github.com> Date: Wed, 24 Apr 2019 21:08:41 +0800 Subject: [PATCH 6/7] fixing FROM rule --- sample_rules/osbs.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sample_rules/osbs.yaml b/sample_rules/osbs.yaml index a0f5c06..8f29730 100644 --- a/sample_rules/osbs.yaml +++ b/sample_rules/osbs.yaml @@ -85,7 +85,8 @@ - "#from" - label: "no_tag" - regex: /^[:]/ + regex: /:/ + inverse_rule: true level: "warn" message: "No tag is used" description: "lorem ipsum tar" From b6e7c7d9f79b2cbd39038caf80481ba75f63fd41 Mon Sep 17 00:00:00 2001 From: 644262163 <31299382+644262163@users.noreply.github.com> Date: Thu, 25 Apr 2019 22:20:12 +0800 Subject: [PATCH 7/7] fixing test from image http://dockerfile.github.io/#/ubuntu --- test/data/dockerfiles/TestLabels | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/data/dockerfiles/TestLabels b/test/data/dockerfiles/TestLabels index 0f49be4..ba15aa5 100644 --- a/test/data/dockerfiles/TestLabels +++ b/test/data/dockerfiles/TestLabels @@ -5,7 +5,7 @@ # # Pull base image. -FROM dockerfile/ubuntu +FROM ubuntu:14.04 # Install Nginx.