Switch to using "repo secret" method for catalog URL & credentials #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
feat/repo-secret
branch
from
3aa12b5 to
5e822e0
Compare
|
Tested against a local cluster with updated steward (cf. projectsyn/steward#181 ) |
|
NOTE: This is technically a breaking change for clusters that use HTTPS catalogs (since those catalogs will always have externally managed repo secrets). My plan was to release this and the update to ArgoCD v3 as a new major component version. edit: We probably want to write a migration how-to noting that users must update their HTTPS catalog repo secrets to work with the new label-based setup. |
DebakelOrakel
approved these changes
Oct 29, 2025
simu
force-pushed
the
feat/repo-secret
branch
from
5e822e0 to
ad6da00
Compare
Externally managed https catalog secrets must be updated to have label `argocd.argoproj.io/secret-type=repo-creds` and must have `url: <catalog url>` so ArgoCD can match them to the repository secret.
simu
force-pushed
the
feat/repo-secret
branch
3 times, most recently
from
cc83c21 to
0ea2ca9
Compare
* Add upgrade how-to * Adjust parameters docs
simu
force-pushed
the
feat/repo-secret
branch
from
0ea2ca9 to
5c94c46
Compare
bastjan
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Externally managed https catalog secrets must be updated to have label
argocd.argoproj.io/secret-type=repo-credsand must haveurl: <catalog url>so ArgoCD can match them to the repository secret.Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog.