feat: add ipmi_sel_events_time #226
Conversation
Signed-off-by: happyfx <happyfx@mayflower.work>
HappyFX
force-pushed
the
feat--add-event-logs
branch
from
212973f to
f4adc95
Compare
|
Hello, can you check the PR? |
|
@RichiH maybe you can check this PR? |
|
Now, I'll be honest: I am not sure what it is you are ultimately trying to achieve, but you should really consider ingesting your SEL into a logging solution of your choice, because it looks like you are trying (again) to use Prometheus as a log monitoring platform, which it isn't. Yes, cardinality is somewhat reduced from your original proposal, but that doesn't make this right. I also don't understand why the custom event mechanism, which is extremely flexible, does not work for you? In general, I don't think the SEL metrics should be expanded any further, because metrics are not about logs. I would at most be willing to make two concessions: I am ok with including the |
2 participants
Add
typeinipmi_sel_events_count_by_state- so it can be distinguish between sel eventsipmi_sel_events_count_by_state{type="Power Supply",state="Critical"} 18Add new metric about more detailed resent time occurrence event in log, so it can be stored in prometheus even after sel log was cleared.
It's not 1-1 sel log event copy, so it won't be with big cardinality. 18 real event are presented as 4 metrics with resent time occurrence
ipmi_sel_events_time{event="Power Supply Failure detected",name="Power Supply 2 Status",state="Critical",type="Power Supply"} 1.731064451e+09 ipmi_sel_events_time{event="Power Supply Failure detected ; Fan Fault",name="Power Supply 2 Status",state="Critical",type="Power Supply"} 1.731064449e+09 ipmi_sel_events_time{event="Power Supply input lost (AC/DC)",name="Power Supply 2 Status",state="Critical",type="Power Supply"} 1.727789819e+09 ipmi_sel_events_time{event="Redundancy Lost",name="System Board PS Redundancy",state="Critical",type="Power Supply"} 1.731064452e+09Original sel-log for example above: