-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add support for reloading ssl at runtime #1277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dhoard I added basic/minimal reloading mechanism. Currently it reloads every hour regardless whether the file has changed. This can be enhanced by checking every n amount of time as interval whether the file has been updated and then reload the ssl. Next to that I refactored the code a bit. I temporally removed the exclusion of slf4j as I didn't know how to properly resolve the failing tests as the library depends on slf4j. Wdyt of the initial PR, is this something what would work out for you? Or do you prefer a different kind of solution. So should we polish/adjust this PR or close it, looking forward to get your feedback on it? |
|
@Hakky54 Thanks for the PR!!! I will discuss with the team whether we want to go with this approach or whether we should implement a full reload at the agent/standalone level. |
Sure, thats fine. Looking forward to the outcome. I have adjusted the implementation by the way. It now checks every hour for files changes and updates only if the files have been modified. |
Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
|
Hi @dhoard did you had a change to discuss with the team regarding this PR, do you want me to adjust something about it? |
|
@Hakky54 Looking at the library, it appears you have a dependency on slf4j. Is that correct? |
|
It was having a dependency on slf4j, but not anymore as I have removed it |
|
@Hakky54 great. The only change I see is that the shadowing needs to be updated to include the package. Once done, I’ll merge. Thanks is for the PR! |
Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
|
That is great to hear! I am not sure how to include the package for shadowing. Can you point me into the right direction? |
|
@Hakky54 you should be able to add your package here: jmx_exporter/jmx_prometheus_javaagent/pom.xml Lines 179 to 187 in 8925c9c
|
Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
|
@dhoard thank you, and done. I added the shading for the package |
PR related to feature request #1114