Skip to content

Conversation

@Hakky54
Copy link
Contributor

@Hakky54 Hakky54 commented Jul 14, 2025

PR related to feature request #1114

@Hakky54
Copy link
Contributor Author

Hakky54 commented Jul 14, 2025

@dhoard I added basic/minimal reloading mechanism. Currently it reloads every hour regardless whether the file has changed. This can be enhanced by checking every n amount of time as interval whether the file has been updated and then reload the ssl. Next to that I refactored the code a bit. I temporally removed the exclusion of slf4j as I didn't know how to properly resolve the failing tests as the library depends on slf4j.

Wdyt of the initial PR, is this something what would work out for you? Or do you prefer a different kind of solution. So should we polish/adjust this PR or close it, looking forward to get your feedback on it?

@dhoard
Copy link
Collaborator

dhoard commented Jul 23, 2025

@Hakky54 Thanks for the PR!!!

I will discuss with the team whether we want to go with this approach or whether we should implement a full reload at the agent/standalone level.

@Hakky54
Copy link
Contributor Author

Hakky54 commented Jul 24, 2025

I will discuss with the team whether we want to go with this approach or whether we should implement a full reload at the agent/standalone level.

Sure, thats fine. Looking forward to the outcome. I have adjusted the implementation by the way. It now checks every hour for files changes and updates only if the files have been modified.

Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
@Hakky54
Copy link
Contributor Author

Hakky54 commented Oct 21, 2025

Hi @dhoard did you had a change to discuss with the team regarding this PR, do you want me to adjust something about it?

@dhoard
Copy link
Collaborator

dhoard commented Nov 8, 2025

@Hakky54 Looking at the library, it appears you have a dependency on slf4j.

Is that correct?

@Hakky54
Copy link
Contributor Author

Hakky54 commented Nov 8, 2025

It was having a dependency on slf4j, but not anymore as I have removed it

@dhoard
Copy link
Collaborator

dhoard commented Nov 8, 2025

@Hakky54 great. The only change I see is that the shadowing needs to be updated to include the package. Once done, I’ll merge.

Thanks is for the PR!

Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
@Hakky54
Copy link
Contributor Author

Hakky54 commented Nov 8, 2025

That is great to hear! I am not sure how to include the package for shadowing. Can you point me into the right direction?

@dhoard
Copy link
Collaborator

dhoard commented Nov 12, 2025

@Hakky54 you should be able to add your package here:

<includes>
<include>com.**</include>
<include>google.**</include>
<include>io.**</include>
<include>kotlin.**</include>
<include>okhttp3.**</include>
<include>okio.**</include>
<include>org.**</include>
</includes>

Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
@Hakky54
Copy link
Contributor Author

Hakky54 commented Nov 12, 2025

@dhoard thank you, and done. I added the shading for the package

@dhoard dhoard merged commit efc6e6c into prometheus:main Nov 12, 2025
2 checks passed
@dhoard dhoard added this to the 1.6.0 milestone Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants