fix(tests): 🐛 Replace Set-Location with Push-Location and Pop-Location

HeyItsGilbert · HeyItsGilbert · commit d16ac614fa77 · 2025-03-31T17:02:42.000-07:00
* Ensures proper stack management for directory changes in tests.
* Improves cleanup in `AfterAll` by restoring the previous location.
diff --git a/tests/build.tests.ps1 b/tests/build.tests.ps1
@@ -4,7 +4,7 @@ Describe 'Build' {
     BeforeAll {
         $tempDir = Join-Path $TestDrive 'TestModule'
         Copy-Item $PSScriptRoot/fixtures/TestModule $tempDir -Recurse
-        Set-Location $tempDir
+        Push-Location $tempDir
 
         # Capture any of the jobs for cleanup later
         [array]$script:jobs = @()
@@ -14,6 +14,7 @@ Describe 'Build' {
     }
 
     AfterAll {
+        Pop-Location
         $jobs | Stop-Job -ErrorAction Ignore
         $jobs | Remove-Job -ErrorAction Ignore
     }

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ Describe 'Build' {`
`4`	`4`	`BeforeAll {`
`5`	`5`	`$tempDir = Join-Path $TestDrive 'TestModule'`
`6`	`6`	`Copy-Item $PSScriptRoot/fixtures/TestModule $tempDir -Recurse`
`7`		`- Set-Location $tempDir`
	`7`	`+ Push-Location $tempDir`
`8`	`8`
`9`	`9`	`# Capture any of the jobs for cleanup later`
`10`	`10`	`[array]$script:jobs = @()`
`@@ -14,6 +14,7 @@ Describe 'Build' {`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`AfterAll {`
	`17`	`+ Pop-Location`
`17`	`18`	`$jobs \| Stop-Job -ErrorAction Ignore`
`18`	`19`	`$jobs \| Remove-Job -ErrorAction Ignore`
`19`	`20`	`}`