-
Notifications
You must be signed in to change notification settings - Fork 96
Support for open_basedir containing more then one paths set #89
Copy link
Copy link
Open
Labels
Description
Currently, if you open_basedir contains more then one path, for example:
open_basedir="/var/www:/php/tmp_cache"
consraints included in CheckSoapWsdlCacheDir and CheckUploadTmpDir are not passing at:
if ($openBasedir === false) {
$this->setDescription('The open_basedir did not resolve to a valid directory');
$this->fail();
return false;
}
due to realpath usage, which returns false for coma separated paths:
$openBasedir = realpath($openBasedir);
The idea is to split $openBasedir by PATH_SEPARATOR into an array of $openBasedirPaths and to check each one of them against included rules.
The question is, how should I treat it. If one of paths === false, then should entire test fails? Or maybe all of them should be equal false?
What do you think about it? I can prepare tommorow appropriate patch.
Reactions are currently unavailable