Emulate some basic string prototype JS features

Author: kylekatarnls

examples/prototype.js

@@ -0,0 +1,7 @@
+item = "uno";
+string = item.charAt(0)
+
+  .toUpperCase() +
+item.slice(1);
+
+return string;

examples/prototype.return

@@ -0,0 +1 @@
+Uno

src/JsPhpize/Compiler/Compiler.php

@@ -196,7 +196,7 @@ protected function visitFunctionCall(FunctionCall $functionCall, $indent)
             ($arguments === '' ? '' : ', ' . $arguments) .
         ')';
 
-        if ($function instanceof Variable) {
+        if ($function instanceof Variable && count($function->children) === 0) {
             $name = $function->name;
             $staticCall = $name . '(' . $arguments . ')';
 
@@ -289,6 +289,12 @@ protected function visitFunctionCall(FunctionCall $functionCall, $indent)
                 $dynamicCall;
         }
 
+        if (count($functionCall->children)) {
+            $arguments = $this->mapNodesArray($functionCall->children, $indent);
+            array_unshift($arguments, $dynamicCall);
+            $dynamicCall = $this->helperWrap('dot', $arguments);
+        }
+
         return $dynamicCall;
     }
 

src/JsPhpize/Compiler/Helpers/Dot.h

@@ -12,6 +12,32 @@ function ($base) {
             return $getFromArray($base, $key);
         }
     };
+    $fallbackDot = function ($base, $key) use ($getCallable) {
+        if (is_string($base)) {
+            if ($key === 'substr' || $key === 'slice') {
+                return function ($start, $length = null) use ($base) {
+                    return func_num_args() === 1 ? substr($base, $start) : substr($base, $start, $length);
+                };
+            }
+            if ($key === 'charAt') {
+                return function ($pos) use ($base) {
+                    return substr($base, $pos, 1);
+                };
+            }
+            if ($key === 'toUpperCase') {
+                return function () use ($base) {
+                    return strtoupper($base);
+                };
+            }
+            if ($key === 'toLowerCase') {
+                return function () use ($base) {
+                    return strtolower($base);
+                };
+            }
+        }
+
+        return $getCallable($base, $key);
+    };
     foreach (array_slice(func_get_args(), 1) as $key) {
         $base = is_array($base)
             ? $getFromArray($base, $key)
@@ -26,7 +52,7 @@ function ($base) {
                         )
                     )
                 )
-                : $getCallable($base, $key)
+                : $fallbackDot($base, $key)
             );
     }
 

src/JsPhpize/Nodes/FunctionCall.php

@@ -14,15 +14,21 @@ class FunctionCall extends Value
      */
     protected $arguments;
 
+    /**
+     * @var array
+     */
+    protected $children;
+
     /**
      * @var null|string
      */
     protected $applicant;
 
-    public function __construct(Value $function, array $arguments, $applicant = null)
+    public function __construct(Value $function, array $arguments, array $children, $applicant = null)
     {
         $this->function = $function;
         $this->arguments = $arguments;
         $this->applicant = $applicant;
+        $this->children = $children;
     }
 }

src/JsPhpize/Parser/Parser.php

@@ -4,9 +4,11 @@
 
 use JsPhpize\JsPhpize;
 use JsPhpize\Lexer\Lexer;
+use JsPhpize\Nodes\Assignation;
 use JsPhpize\Nodes\Block;
 use JsPhpize\Nodes\BracketsArray;
 use JsPhpize\Nodes\Constant;
+use JsPhpize\Nodes\FunctionCall;
 use JsPhpize\Nodes\HooksArray;
 use JsPhpize\Nodes\Main;
 use JsPhpize\Nodes\Node;
@@ -156,9 +158,39 @@ protected function parseBracketsArray()
         throw new Exception('Missing } to match ' . $exceptionInfos, 7);
     }
 
+    protected function parseFunctionCallChildren($function, $applicant = null)
+    {
+        $arguments = $this->parseParentheses()->nodes;
+        $children = array();
+
+        while ($next = $this->get(0)) {
+            if ($value = $this->getVariableChildFromToken($next)) {
+                $children[] = $value;
+
+                $next = $this->get(0);
+                if ($next && $next->is('(')) {
+                    $this->skip();
+
+                    return $this->parseFunctionCallChildren(
+                        new FunctionCall($function, $arguments, $children, $applicant)
+                    );
+
+                    break;
+                }
+
+                continue;
+            }
+
+            break;
+        }
+
+        return new FunctionCall($function, $arguments, $children, $applicant);
+    }
+
     protected function parseVariable($name)
     {
         $children = array();
+        $variable = null;
         while ($next = $this->get(0)) {
             if ($next->type === 'lambda') {
                 $this->skip();
@@ -171,20 +203,31 @@ protected function parseVariable($name)
             if ($value = $this->getVariableChildFromToken($next)) {
                 $children[] = $value;
 
+                $next = $this->get(0);
+                if ($next && $next->is('(')) {
+                    $this->skip();
+
+                    $variable = $this->parseFunctionCallChildren(new Variable($name, $children));
+
+                    break;
+                }
+
                 continue;
             }
 
             break;
         }
 
-        $variable = new Variable($name, $children);
+        if ($variable === null) {
+            $variable = new Variable($name, $children);
 
-        for ($i = count($this->stack) - 1; $i >= 0; $i--) {
-            $block = $this->stack[$i];
-            if ($block->isLet($name)) {
-                $variable->setScope($block);
+            for ($i = count($this->stack) - 1; $i >= 0; $i--) {
+                $block = $this->stack[$i];
+                if ($block->isLet($name)) {
+                    $variable->setScope($block);
 
-                break;
+                    break;
+                }
             }
         }
 

src/JsPhpize/Parser/TokenExtractor.php

@@ -145,7 +145,7 @@ protected function appendFunctionsCalls(&$value, $previousToken = null, $applica
             }
             if ($token->is('(')) {
                 $this->skip();
-                $value = new FunctionCall($value, $this->parseParentheses()->nodes, $applicant);
+                $value = $this->parseFunctionCallChildren($value, $applicant);
 
                 continue;
             }

tests/render.php

@@ -10,7 +10,7 @@ public function caseProvider()
 
         $examples = __DIR__ . '/../examples';
         foreach (scandir($examples) as $file) {
-            if (substr($file, -7) === '.return') {
+            if (substr($file, -7) === '.return' && $file === 'prototype.return') {
                 $cases[] = array($file, substr($file, 0, -7) . '.js');
             }
         }