(MAINT) Rubocop Corrections

- Layout/ClosingParenthesisIndentation
- RSpec/NamedSubject
- Style/Documentation

Author: david22swan

.rubocop_todo.yml

@@ -6,14 +6,6 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 8
-# Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
-# SupportedStyles: always, named_only
-RSpec/NamedSubject:
-  Exclude:
-    - 'spec/classes/certificates_spec.rb'
-    - 'spec/classes/redact_spec.rb'
-
 # Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.

Gemfile

@@ -99,8 +99,6 @@ extra_gemfiles = [
 extra_gemfiles.each do |gemfile|
   next unless File.file?(gemfile) && File.readable?(gemfile)
 
-  # rubocop:disable Security/Eval
-  eval(File.read(gemfile), binding)
-  # rubocop:enable Security/Eval
+  eval(File.read(gemfile), binding) # rubocop:disable Security/Eval
 end
 # vim: syntax=ruby

lib/puppet/parser/functions/node_encrypt.rb

@@ -8,7 +8,7 @@
                                         This function simply encrypts the String or Sensitive passed to it using the certificate
                                         belonging to the client the catalog is being compiled for.
                                       DOC
-) do |args|
+                                     ) do |args|
   content = args.first
   content = content.unwrap if defined?(Puppet::Pops::Types::PSensitiveType::Sensitive) && content.is_a?(Puppet::Pops::Types::PSensitiveType::Sensitive)
 

lib/puppet_x/node_encrypt.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
 
 module PuppetX
-  class NodeEncrypt # rubocop:disable Style/Documentation
+  # Helper class for encrypting and decrypting data for nodes
+  class NodeEncrypt
     def self.encrypted?(data)
       raise ArgumentError, 'Only strings can be encrypted' unless data.instance_of?(String)
 

spec/classes/certificates_spec.rb

@@ -4,6 +4,8 @@
 require 'puppet_x/node_encrypt'
 
 describe 'node_encrypt::certificates' do
+  subject(:node_encrypt_certificates) { catalogue }
+
   before(:each) do
     Puppet[:ca_server] = 'ca.example.com'
     Puppet[:confdir]   = '/etc/puppetlabs/puppet'
@@ -23,7 +25,7 @@
     end
 
     it {
-      expect(subject).to contain_ini_setting('public certificates mountpoint path').with(
+      expect(node_encrypt_certificates).to contain_ini_setting('public certificates mountpoint path').with(
         {
           ensure: 'present',
           path: '/etc/puppetlabs/puppet/fileserver.conf',
@@ -33,7 +35,7 @@
     }
 
     it {
-      expect(subject).to contain_puppet_authorization__rule('public certificates mountpoint whitelist').with(
+      expect(node_encrypt_certificates).to contain_puppet_authorization__rule('public certificates mountpoint whitelist').with(
         {
           match_request_path: '^/puppet/v3/file_(metadata|content)s?/public_certificates',
           match_request_type: 'regex',
@@ -60,7 +62,7 @@
     it { is_expected.not_to contain_ini_setting('public certificates mountpoint whitelist') }
 
     it {
-      expect(subject).to contain_file('/etc/puppetlabs/puppet/ssl/certs').with(
+      expect(node_encrypt_certificates).to contain_file('/etc/puppetlabs/puppet/ssl/certs').with(
         {
           ensure: 'directory',
           source: 'puppet://ca.example.com/public_certificates/'

spec/classes/redact_spec.rb

@@ -3,6 +3,8 @@
 require 'spec_helper'
 
 describe 'redact' do
+  subject(:function_redact) { catalogue }
+
   let(:node) { 'test.example.com' }
   let(:facts) do
     {
@@ -18,7 +20,7 @@
   end
 
   it {
-    expect(subject).to contain_class('redact').with(
+    expect(function_redact).to contain_class('redact').with(
       {
         param: 'a param',
         redacted: '<<redacted>>',
@@ -28,7 +30,7 @@
   }
 
   it {
-    expect(subject).to contain_redact__thing('one').with(
+    expect(function_redact).to contain_redact__thing('one').with(
       {
         param: 'a param',
         redacted: '<<redacted>>',
@@ -38,7 +40,7 @@
   }
 
   it {
-    expect(subject).to contain_redact__thing('two').with(
+    expect(function_redact).to contain_redact__thing('two').with(
       {
         param: 'a param',
         redacted: '<<redacted>>',
@@ -48,7 +50,7 @@
   }
 
   it {
-    expect(subject).to contain_redact__thing('three').with(
+    expect(function_redact).to contain_redact__thing('three').with(
       {
         param: 'a param',
         redacted: '<<redacted>>',
@@ -58,7 +60,7 @@
   }
 
   it {
-    expect(subject).to contain_redact__thing('four').with(
+    expect(function_redact).to contain_redact__thing('four').with(
       {
         param: 'a param',
         redacted: '<<redacted>>',