Bugfix: Delete the try in Combinators.Array.many

According to the semantics of “consume”:

If the phrase parser fails without consuming then that is the end of the
many.
If the phrase parser fails after consuming then the whole parse has
failed.

Author: jamesdbrock

CHANGELOG.md

@@ -7,6 +7,8 @@ Notable changes to this project are documented in this file. The format is based
 Bugfixes:
 - `float` parser of `GenTokenParser` does not parse negative numbers (by @mstream)
 - Fixes `consumed` semantics which could cause unexpected backtracking instead of a failure (by @natefaubion)
+- Fix `Combinators.Array.many` and `Combinators.Array.many1`. If the phrase fails after consuming
+  then the combinator fails. (#240 by @jamesdbrock)
 
 Breaking changes:
 

src/Parsing/Combinators.purs

@@ -207,8 +207,12 @@ lookAhead (ParserT k1) = ParserT
 
 -- | Match the phrase `p` as many times as possible.
 -- |
--- | If `p` never consumes input when it
--- | fails then `many p` will always succeed,
+-- | Will match until the phrase `p` fails *without consuming*.
+-- |
+-- | If the phrase `p` fails after consuming input then the `many` will fail.
+-- |
+-- | If the phrase `p` is wrapped in `try` then it will never consume.
+-- | If phrase `p` never consumes then `many p` will always succeed,
 -- | but may return an empty list.
 many :: forall s m a. ParserT s m a -> ParserT s m (List a)
 many = List.manyRec

src/Parsing/Combinators/Array.purs

@@ -28,18 +28,21 @@ import Data.List (List(..), (:))
 import Data.Maybe (Maybe(..))
 import Data.Tuple (Tuple(..))
 import Parsing (ParseError(..), ParserT, fail, parseErrorMessage, parseErrorPosition)
-import Parsing.Combinators (try)
 
 -- | Match the phrase `p` as many times as possible.
 -- |
--- | If `p` never consumes input when it
--- | fails then `many p` will always succeed,
+-- | Will match until the phrase `p` fails *without consuming*.
+-- |
+-- | If the phrase `p` fails after consuming input then the `many` will fail.
+-- |
+-- | If the phrase `p` is wrapped in `try` then it will never consume.
+-- | If phrase `p` never consumes then `many p` will always succeed,
 -- | but may return an empty array.
 many :: forall s m a. ParserT s m a -> ParserT s m (Array a)
 many p = do
   rlist <- flip tailRecM Nil $ \xs -> alt
     do
-      x <- try p
+      x <- p
       pure (Loop (x : xs))
     do
       pure (Done xs)