Import all issues from zaru/webpush (will be fixed by this fork)

[collimarco]

A list of all the issues and pull requests that are currently open on zaru/webpush and that we are going to fix with this fork:

Issues

• Safari 16 on MacOS now supports the Push API, but push messages fail zaru/webpush#110
• Windows Push Notification Services: 406 Not Acceptable zaru/webpush#109
• Looking for a new maintainer? zaru/webpush#107
• No error handling? zaru/webpush#104
• Fix VAPID default values (merge pull requests) zaru/webpush#102
• Fix to_pem in new Ruby versions (merge pull request) zaru/webpush#98
• Intermittent Webpush::Unauthorized errors from FCM zaru/webpush#89
• How to handle Net::HTTPBadRequest 400 InvalidTokenFormat? zaru/webpush#52

Pull requests

• Add support for OpenSSL 3 zaru/webpush#106
• Update hkdf gem to 1.0.0 zaru/webpush#105
• Treat 406 from Microsoft as 429 zaru/webpush#103
• Change VAPID expiration from 24h to 12h zaru/webpush#101
• Fix wrong default value for VAPID subject zaru/webpush#100
• Fix vapid key to_pem zaru/webpush#97

[collimarco]

Notes:

• Apple Push Service currently has a bug that cannot be fixed by this gem and you need to set urgency to high as a workaround
• Windows Notification Service has a bug and currently return 406 instead of 429 for rate limiting (it's still in consideration if we should fix this strange behavior inside this gem or not)
• We may consider, as an enhancement (not a bug), to catch some exceptions when the subscription fields (endpoint, keys, etc.) are malformed and raise some specific WebPush errors instead (see my comment for details)
• We need to upgrade to OpenSSL v3 (see pull request) Fixed: v3 now supports OpenSSL 3

[collimarco]

All the issues and pull requests that are not listed in the "Notes" are solved by this fork.

[marckohlbrugge]

All the issues and pull requests that are not listed in the "Notes" are solved by this fork.

Thanks for your work on this! Could you please clarify what you mean with "Notes" ?

E.g. I noticed the OpenSSL issue isn't resolved yet (pkeys are immutable on OpenSSL 3.0 (OpenSSL::PKey::PKeyError in v2.1.0), but the first message in thread makes it seem like it's completed already.

[collimarco]

@marckohlbrugge The notes in my comment above are issues imported from zaru/webpush that aren't solved yet by this fork. In any case we already use this gem in production, so they are not severe issues.

[marckohlbrugge]

@collimarco Sorry, I somehow totally missed that second comment with the notes.

I was able to manually pull in some of the changes from zaru/webpush#106 into your branch and it seems to work 👍

[collimarco]

@marckohlbrugge The OpenSSL issue is now resolved. You can use this fork with OpenSSL v3.

[francogp]

I'm getting 406 Not Acceptable since yesterday, from microsoft edge notifications (I sent only 8).

[collimarco]

The Apple bug with "urgency" header is resolved now.