Support Ansible Modules

[JakkuSakura]

Sometimes a vendor provides ansible modules, but maybe not pyinfra ones. It would be good to have some level of support for them

def aptclean(m):
    clean_rc, clean_out, clean_err = m.run_command(['apt-get', 'clean'])
    clean_diff = parse_diff(clean_out) if m._diff else {}

    if clean_rc:
        m.fail_json(msg="apt-get clean failed", stdout=clean_out, rc=clean_rc)
    if clean_err:
        m.fail_json(msg="apt-get clean failed: %s" % clean_err, stdout=clean_out, rc=clean_rc)
    return (clean_out, clean_err, clean_diff)

[kimjarvis]

The ansible playbook command writes a file, for example AnsiballZ_dnf.py, to a temp directory on all the hosts in the inventory and then executes it. Ideally, Pyinfra should do the same thing for modules that are not directly supported. I see where you are going with the snippet above. But, how to work the inventory into that ?

[JakkuSakura]

I mean to support modules at https://github.com/ansible/ansible/tree/devel/lib/ansible/modules, not from some temp directories

From my observation, these modules are plain python file with a few functions and no dependency on ansible modules

def aptclean(m):
    clean_rc, clean_out, clean_err = m.run_command(['apt-get', 'clean'])
    clean_diff = parse_diff(clean_out) if m._diff else {}

    if clean_rc:
        m.fail_json(msg="apt-get clean failed", stdout=clean_out, rc=clean_rc)
    if clean_err:
        m.fail_json(msg="apt-get clean failed: %s" % clean_err, stdout=clean_out, rc=clean_rc)
    return (clean_out, clean_err, clean_diff)

We could make similar m

class AnsibleModuleAdapter:
     def run_command(self): ...
     def fail_json(self): ...

and pass it as m

[JakkuSakura]

PyInfra doesn't necessarily need to send the modules to remote machine to execute them, if the modules is compilant to use m extensively. But if a module involves calling things on remote host, executing them on remote host seems a must, but shouldn't be hard for pyinfra.
With this design, pyinfra is a python way of writing ansible, instead of the crappy yaml.
I don't see how inventories are involved here. we can just parse inventory files or ask for a rewrite, but that's the easy part either way

[mtparet]

It would be really interesting to support ansible module "best effort/bridge", at least for the mid-term where it can be challenging using pyinfra because lot of things are already available in ansible.