-
Notifications
You must be signed in to change notification settings - Fork 314
Deploy Pyth on Celo Sepolia testnet #3274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| }, | ||
| { | ||
| "chain": "celo_sepolia_testnet", | ||
| "address": "0x2880aB155794e7179c9eE2e38200202908C17B43", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the proxy address. The impl contract is at 0xA2aa501b19aff244D90cc15a4Cf739D2725B5729. I assume the proxy is what we want here, but it seems some entries in this file point to the impl and I'm unclear on why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't. The contract address can differ on different chains. That might be the reason behind this confusion.
| }, | ||
| { | ||
| "chain": "celo_sepolia_testnet", | ||
| "address": "0x2880aB155794e7179c9eE2e38200202908C17B43", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't. The contract address can differ on different chains. That might be the reason behind this confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is correct. @cprussin Can you check this?
I don't see why these changes are needed for contract deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like something reformatted the file, but it doesn't look like it made any actual changes. Maybe just revert this @azellers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure I don't have any yaml autoformatter configured that would mess with this file, and I don't think I ever edited it anyway. I wonder if I have a different version of pnpm and that is rewriting this file as a side effect of running commands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's entirely possible, however we have packageManagerStrictVersion enabled which should prevent you from having a different version, and generally pnpm only writes this file under very specific scenarios. I would just revert it and if you see a command change it again maybe ping me and let me know what's changing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, at some point I ran pnpm install tsx which is what did this. It wasn't necessary- there is already an entry for tsx and it didn't change after running that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh ok, weird that that would change the workspace file, but I guess that's fine. In any case if you do use the pnpm cli to install stuff moving forward and it changes the file, just run pnpm turbo //#fix afterwards (//# is this weird turborepo thing that runs tasks for files that aren't in any packages)
Summary
Rationale
Celo is moving to a new testnet
How has this been tested?
Confirmed contract exists on testnet, verified contract code.