Gui/small fixes (#1426)

* UI: Fix Rect.center providing bottom left
* UI: Fix UIManager.clear()
* UI: Fix UILabel support multiline

Author: eruvanos

arcade/gui/ui_manager.py

@@ -105,6 +105,9 @@ def remove(self, child: UIWidget):
                 children.remove(child)
                 child.parent = None
                 self.trigger_render()
+            else:
+                print()
+        print()
 
     def walk_widgets(self, *, root: Optional[UIWidget] = None) -> Iterable[UIWidget]:
         """walks through widget tree, in reverse draw order (most top drawn widget first)"""
@@ -119,7 +122,7 @@ def clear(self):
         Remove all widgets from UIManager
         """
         for layer in self.children.values():
-            for widget in layer:
+            for widget in layer[:]:
                 self.remove(widget)
 
     def get_widgets_at(self, pos, cls=UIWidget) -> Iterable[W]:

arcade/gui/widgets/__init__.py

@@ -102,7 +102,7 @@ def center_y(self):
 
     @property
     def center(self):
-        return self.left, self.bottom
+        return self.center_x, self.center_y
 
     @property
     def position(self):

arcade/gui/widgets/text.py

@@ -77,8 +77,8 @@ def __init__(
             font_name=font_name,
             font_size=font_size,
             color=arcade.get_four_byte_color(text_color),
-            width=None,
-            height=None,
+            width=width,
+            height=height,
             bold=bold,
             italic=italic,
             stretch=stretch,

tests/test_gui/test_rect.py

@@ -60,6 +60,14 @@ def test_rect_align_center_y():
     assert new_rect == (10, -50, 100, 200)
 
 
+def test_rect_center():
+    # WHEN
+    rect = Rect(0, 0, 100, 200)
+
+    # THEN
+    assert rect.center == (50, 100)
+
+
 def test_rect_align_top():
     # GIVEN
     rect = Rect(10, 20, 100, 200)

tests/test_gui/test_uimanager.py

@@ -70,7 +70,11 @@ def test_clear_removes_all_children(window):
     widget1 = UIDummy(x=50, y=50, width=100, height=100)
     manager.add(widget1)
 
+    widget2 = UIDummy(x=50, y=50, width=100, height=100)
+    manager.add(widget2)
+
     manager.clear()
 
     assert widget1.parent is None
+    assert widget2.parent is None
     assert list(manager.walk_widgets()) == []

tests/test_gui/test_widget_inputtext.py

@@ -1,3 +1,4 @@
+from arcade.gui import UILabel
 from arcade.gui.events import UIEvent
 
 from arcade.gui.widgets import UIDummy
@@ -14,3 +15,14 @@ def test_widget():
 
     # THEN
     assert widget.rect == (0, 0, 100, 100)
+
+def test_uilabel_support_multiline(window):
+    # WHEN
+    widget = UILabel(
+        text="Lorem ipsum dolor",
+        width=20,
+        multiline=True,
+    )
+
+    # THEN
+    assert widget is not None