revert: downgrade Ignite to v0.4.4 (#157)

Author: ydcjeff

.github/workflows/ci.yml

@@ -47,7 +47,6 @@ jobs:
       - name: Install dependencies
         run: |
           pip install wheel setuptools pip -Uqq
-          pip install --pre pytorch-ignite
           pip install -r ./scripts/requirements.txt -f https://download.pytorch.org/whl/cpu/torch_stable.html --progress-bar off
           pip uninstall -y tqdm
           npm i -g pnpm
@@ -98,7 +97,7 @@ jobs:
           restore-keys: |
             pnpm-and-pip-cache-
 
-      - run: pip install -Uq pip wheel && pip install -Uq "black==20.8b1" "isort==5.7.0"
+      - run: pip install -Uq pip wheel && sh scripts/run_code_style.sh install
       - run: npm i -g pnpm
       - run: pnpm i --frozen-lockfile --color
       - run: pnpm lint

scripts/run_code_style.sh

@@ -5,9 +5,10 @@ set -xeu
 if [ $1 == "lint" ]; then
     black . -l 80 --check
     isort . --profile black --check
+    flake8 --select F401 .  # find unused imports
 elif [ $1 == "fmt" ]; then
     isort . --profile black
     black . -l 80
 elif [ $1 == "install" ]; then
-    pip install "black==20.8b1" "isort==5.7.0"
+    pip install "black==20.8b1" "isort==5.7.0" flake8
 fi

src/templates/template-common/main.py

@@ -4,7 +4,14 @@
 
 #::: if (it.logger) { :::#
 if rank == 0:
-    exp_logger.close()
+    from ignite.contrib.handlers.wandb_logger import WandBLogger
+
+    if isinstance(exp_logger, WandBLogger):
+        # why handle differently for wandb?
+        # See: https://github.com/pytorch/ignite/issues/1894
+        exp_logger.finish()
+    elif exp_logger:
+        exp_logger.close()
 #::: } :::#
 
 #::: if (it.save_training || it.save_evaluation) { :::#

src/templates/template-text-classification/main.py

@@ -5,8 +5,8 @@
 import ignite.distributed as idist
 import yaml
 from data import setup_data
+from ignite.contrib.handlers import LRScheduler, PiecewiseLinear
 from ignite.engine import Events
-from ignite.handlers.param_scheduler import LRScheduler, PiecewiseLinear
 from ignite.metrics import Accuracy, Loss
 from ignite.utils import manual_seed
 from models import TransformerModel
@@ -157,7 +157,14 @@ def _():
     #::: if (it.logger) { :::#
     # close logger
     if rank == 0:
-        exp_logger.close()
+        from ignite.contrib.handlers.wandb_logger import WandBLogger
+
+        if isinstance(exp_logger, WandBLogger):
+            # why handle differently for wandb?
+            # See: https://github.com/pytorch/ignite/issues/1894
+            exp_logger.finish()
+        elif exp_logger:
+            exp_logger.close()
     #::: } :::#
     #
     #::: if (it.save_training || it.save_evaluation) { :::#

src/templates/template-vision-classification/main.py

@@ -113,7 +113,14 @@ def _():
     #::: if (it.logger) { :::#
     # close logger
     if rank == 0:
-        exp_logger.close()
+        from ignite.contrib.handlers.wandb_logger import WandBLogger
+
+        if isinstance(exp_logger, WandBLogger):
+            # why handle differently for wandb?
+            # See: https://github.com/pytorch/ignite/issues/1894
+            exp_logger.finish()
+        elif exp_logger:
+            exp_logger.close()
     #::: } :::#
     #
     #::: if (it.save_training || it.save_evaluation) { :::#

src/templates/template-vision-dcgan/main.py

@@ -10,7 +10,6 @@
 from ignite.utils import manual_seed
 from models import Discriminator, Generator
 from torch import nn, optim
-from torch.utils.data.distributed import DistributedSampler
 from trainers import setup_evaluator, setup_trainer
 from utils import *
 
@@ -168,7 +167,14 @@ def _():
     #::: if (it.logger) { :::#
     # close logger
     if rank == 0:
-        exp_logger.close()
+        from ignite.contrib.handlers.wandb_logger import WandBLogger
+
+        if isinstance(exp_logger, WandBLogger):
+            # why handle differently for wandb?
+            # See: https://github.com/pytorch/ignite/issues/1894
+            exp_logger.finish()
+        elif exp_logger:
+            exp_logger.close()
     #::: } :::#
     #
     #::: if (it.save_training || it.save_evaluation) { :::#

src/templates/template-vision-dcgan/test_all.py

@@ -1,6 +1,5 @@
 import os
 from argparse import Namespace
-from numbers import Number
 from typing import Iterable
 
 import ignite.distributed as idist

src/templates/template-vision-segmentation/main.py

@@ -4,9 +4,9 @@
 
 import ignite.distributed as idist
 import yaml
-from data import denormalize, download_datasets, setup_data
+from data import denormalize, setup_data
+from ignite.contrib.handlers import LRScheduler
 from ignite.engine import Events
-from ignite.handlers.param_scheduler import LRScheduler
 from ignite.metrics import ConfusionMatrix, IoU, mIoU
 from ignite.utils import manual_seed
 from models import setup_model
@@ -176,7 +176,14 @@ def _():
     #::: if (it.logger) { :::#
     # close logger
     if rank == 0:
-        exp_logger.close()
+        from ignite.contrib.handlers.wandb_logger import WandBLogger
+
+        if isinstance(exp_logger, WandBLogger):
+            # why handle differently for wandb?
+            # See: https://github.com/pytorch/ignite/issues/1894
+            exp_logger.finish()
+        elif exp_logger:
+            exp_logger.close()
     #::: } :::#
     #
     #::: if (it.save_training || it.save_evaluation) { :::#