-
Notifications
You must be signed in to change notification settings - Fork 4.3k
[WIP] New Ray Serve tutorial #3709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3709
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| *.egg-info/ | ||
| .installed.cfg | ||
| *.egg | ||
| .git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed due to a bug in Ray; working on a PR
| "downscale_delay_s": 30, # Wait 30s before scaling down. | ||
| }, | ||
| # Max concurrent requests per replica before queueing. | ||
| # If the queue fills the shared cluster memory, future requests are backpressured until memory is freed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This statement is confusing to me about Ray Serve's backpressure mechanism. Ray Serve relies on max_queued_requests to backpressure requests and not the cluster memory. See the docs for more detail
Adds a new tutorial serving Pytorch models on Ray Serve.
This should be merged after #3694 since otherwise the new Ray version will break the existing Tune tutorial.
I will remove the [WIP] label after the Ray Serve team finishes their review.