qt-python: Show error popup when pip install fails

Author: benchoq

qt-python/src/installer.ts

@@ -175,27 +175,31 @@ async function tryInstallPySide(
     runner.onStdout(logIndented);
     runner.onStderr(logIndented);
 
-    if (source.source === 'oss') {
-      await runner.run('pip install PySide6', { useVenv: true });
-    } else if (source.source === 'local' && source.localPath) {
-      await runner.run('pip install -r requirements.txt', {
-        useVenv: true,
-        cwd: source.localPath
-      });
-    } else {
-      return;
-    }
+    try {
+      if (source.source === 'oss') {
+        await runner.run('pip install PySide6', { useVenv: true });
+      } else if (source.source === 'local' && source.localPath) {
+        await runner.run('pip install -r requirements.txt', {
+          useVenv: true,
+          cwd: source.localPath
+        });
+      } else {
+        return;
+      }
+
+      const pyside6Version = await fetchPySide6Version(env);
+      if (!pyside6Version) {
+        throw new Error('Cannot read PySide6 version');
+      }
 
-    const pyside6Version = await fetchPySide6Version(env);
-    if (pyside6Version) {
       void vscode.window.showInformationMessage(
         texts.install.popup.installed(
           folder.name,
           pyside6Version,
           env.venvName ?? ''
         )
       );
-    } else {
+    } catch (e) {
       void vscode.window.showWarningMessage(
         texts.install.popup.installFailed(folder.name) + ` (${linkShowLogs})`
       );