Skip to content

Commit eb166ce

Browse files
committed
bugfix: 修复OpenAPI describe_git_releases_by_name内部传参异常
1 parent 07f933b commit eb166ce

File tree

5 files changed

+9
-5
lines changed

5 files changed

+9
-5
lines changed

coding_devops_sdk/openapi/client.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ def __init__(self, team=None, token=None):
1919
"""
2020
self.team = team or settings.TEAM
2121
self.token = token or settings.AUTH_TOKEN
22+
if not self.token:
23+
raise ValueError("鉴权令牌不可为空,请设置token参数或传入AUTH_TOKEN配置项。")
2224

2325
def request_api(self, action, **kwargs):
2426
data = {'Action': action}

coding_devops_sdk/openapi/depot.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,8 @@ def describe_project_depot_info_list_by_name(self, project_name: str) -> list:
5454

5555
def get_depot_id_by_name(self, depot_name, project_name=settings.DEFAULT_PROJECT_NAME):
5656
"""
57-
58-
:param project_name:
5957
:param depot_name:
58+
:param project_name:
6059
:return:
6160
"""
6261
if not project_name:
@@ -86,5 +85,5 @@ class IntegratedReleaseAPIMixin(object):
8685
def describe_git_releases_by_name(self, depot_name, project_name=settings.DEFAULT_PROJECT_NAME, **kwargs):
8786
if not project_name:
8887
raise ValueError("project name should be not empty, please set project_name either directly or on project settings")
89-
depot_id = self.get_depot_id_by_name(project_name, depot_name)
88+
depot_id = self.get_depot_id_by_name(depot_name=depot_name, project_name=project_name)
9089
return self.describe_git_releases(depot_id)

coding_devops_sdk/settings.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,5 @@
1+
[default]
2+
# 默认项目
13
DEFAULT_PROJECT_NAME = "@none None"
4+
# 默认仓库
25
DEFAULT_DEPOT_NAME = "@none None"

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ build-backend = "setuptools.build_meta"
55

66
[project]
77
name = "coding-devops-sdk-py"
8-
version = "0.1.0"
8+
version = "0.1.1-beta.1"
99
authors = [
1010
{name = "QuantTide Inc.", email = "opensource@quanttide.com"}
1111
]

tests/test_openapi_depot.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ def test_describe_project_depot_info_list_by_name(self):
1717

1818
def test_get_depot_id_by_name(self):
1919
depot_id = coding_openapi_client.get_depot_id_by_name(
20-
project_name=settings.TEST_PROJECT_NAME,
2120
depot_name=settings.TEST_DEPOT_NAME,
21+
project_name=settings.TEST_PROJECT_NAME,
2222
)
2323
self.assertEqual(settings.TEST_DEPOT_ID, depot_id)
2424

0 commit comments

Comments
 (0)