-
Notifications
You must be signed in to change notification settings - Fork 3
Amz cache tag #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Amz cache tag #473
Conversation
WalkthroughThe handler now always sets Edge-Cache-Tag regardless of CDN provider and adds CloudFront support by setting amzn-cache-tag with the same deduplicated cache keys. Existing Cloudflare headers (Cache-Tag, Surrogate-Key) are retained. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Client
participant Handler as CDN Caching Handler
participant Resp as HTTP Response
Client->>Handler: Incoming request
activate Handler
Handler->>Handler: Compute & deduplicate cacheKeys
note right of Handler #f2f4f8: Edge-Cache-Tag now provider-agnostic
Handler->>Resp: Set header Edge-Cache-Tag: cacheKeys
alt Cloudflare
Handler->>Resp: Set header Cache-Tag: cacheKeys
Handler->>Resp: Set header Surrogate-Key: cacheKeys
end
alt CloudFront
Handler->>Resp: Set header amzn-cache-tag: cacheKeys
end
Handler-->>Client: Response with headers
deactivate Handler
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit