Skip to content

Conversation

@chrisnovakovic
Copy link
Collaborator

The following author-only tests are run as part of the standard test suite:

  • t/local/01_pod.t
  • t/local/02_pod_coverage.t
  • t/local/kwalitee.t

These only need to be run as part of CI jobs and release testing, and are usually skipped on end-user machines anyway (owing to their stealth dependency on the non-core Test::Pod, Test::Pod::Coverage and Test::Kwalitee modules respectively).

Move these tests to the xt/ directory, declare their Test:: dependencies as development prerequisites, and add an xtest target to the generated Makefile that runs these tests.

Closes #392.

The following author-only tests are run as part of the standard test
suite:

* t/local/01_pod.t
* t/local/02_pod_coverage.t
* t/local/kwalitee.t

These only need to be run as part of CI jobs and release testing, and
are usually skipped on end-user machines anyway (owing to their stealth
dependency on the non-core Test::Pod, Test::Pod::Coverage and
Test::Kwalitee modules respectively).

Move these tests to the xt/ directory, declare their Test:: dependencies
as development prerequisites, and add an xtest target to the generated
Makefile that runs these tests.

Closes radiator-software#392.
@chrisnovakovic chrisnovakovic added the tech-debt Technical debt label Apr 3, 2022
@chrisnovakovic chrisnovakovic requested a review from h-vn April 3, 2022 11:51
@chrisnovakovic
Copy link
Collaborator Author

(We're not currently in a position to run these tests as part of a CI workflow because the code doesn't pass them all yet - the only reason they're not already causing failures is because the GHA and AppVeyor test runners don't have the non-core Test:: modules installed, so the tests are skipped.)

Copy link
Contributor

@h-vn h-vn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea. They were almost always skipped when looking through, for example, CPAN Testers reports.

Related to how the tests that are now being moved are run, there's one thing I noted in Changes:

1.57 2014-01-09
Fixed remaining problems with test suite: pod coverage and kwalitee tests
are only enabled with RELEASE_TESTING=1

This variable is also used by t/external/ocsp.t but it no longer enables additional .t files that are now in xt/. There's also this discussion, should it be considered somehow? https://www.perlmonks.org/?node_id=1225311

gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tech-debt Technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Author-only tests are executed as part of make test

2 participants