Replace binary test file with ASCII text file #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisnovakovic
force-pushed
the
GH-475-lorem-ipsum-test-file
branch
from
38a939c to
1133f87
Compare
t/data/binary-test.file is a binary blob of unknown provenance. To provide more reassurance that nothing malicious is hidden in binary blobs in the test suite, replace this file with the ASCII text file t/data/lorem-ipsum.txt, which contains the first two paragraphs of lorem ipsum generated by https://lipsum.com with lines wrapped at 80 characters. Closes radiator-software#475.
Contributor
|
The site gives a different lorem ipsum each time. If we change this, let's find something that's reproducible or well known by some other means. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
t/data/binary-test.fileis a binary blob of unknown provenance. To provide more reassurance that nothing malicious is hidden in binary blobs in the test suite, replace this file with the ASCII text filet/data/lorem-ipsum.txt, which contains the first two paragraphs of lorem ipsum generated by https://lipsum.com with lines wrapped at 80 characters.Closes #475.