[WIP] PR #3 nvimagecodec v0.7.0 #983

cdinea · 2025-11-26T05:29:55Z

Update cuslide2 plugin for nvImageCodec v0.7.0

Description

This PR updates the cucim.kit.cuslide2 plugin to support nvImageCodec v0.7.0 from internal release, which includes new features for direct TIFF tag retrieval and API changes.

Key Changes

1. CMake Configuration (`cmake/deps/nvimgcodec.cmake`)

Updated default version from 0.6.0 to 0.7.0
Added NVIMGCODEC_DIR and NVIMGCODEC_ROOT variables for local installations
Added automatic CUDA version detection (CUDA 12 vs CUDA 13)
Improved library discovery for conda, pip, and system installations

2. API Compatibility Fix (`nvimgcodec_decoder.cpp`)

Breaking change in v0.7.0: Removed buffer_size assignment from nvimgcodecImageInfo_t
- The buffer_size member was removed in v0.7.0; buffer size is now inferred from plane_info

3. TIFF Tag Support (`nvimgcodec_tiff_parser.cpp`)

New in v0.7.0: Added direct TIFF tag retrieval using NVIMGCODEC_METADATA_KIND_TIFF_TAG
Implemented tag querying by ID for:
- SUBFILETYPE (254) - for associated image classification
- COMPRESSION (259) - compression method detection
- IMAGEDESCRIPTION (270) - vendor metadata
- SUBIFD (330) - sub-IFD references
- JPEGTABLES (347) - JPEG quantization/huffman tables

Updated enum values to match v0.7.0 API:

NVIMGCODEC_METADATA_KIND_TIFF_TAG = 1
NVIMGCODEC_METADATA_KIND_MED_APERIO = 5
NVIMGCODEC_METADATA_KIND_MED_PHILIPS = 6
NVIMGCODEC_METADATA_KIND_MED_LEICA = 7
NVIMGCODEC_METADATA_KIND_MED_VENTANA = 8
NVIMGCODEC_METADATA_KIND_MED_TRESTLE = 9

Added support for multiple TIFF value types (ASCII, SHORT, LONG, BYTE, LONG8, RATIONAL)

4. Dependencies (`dependencies.yaml`)

Updated libnvimgcodec and nvimgcodec versions to 0.7.0

-                    uint16_t compression_value = tiff_tag_value_to_uint16(compression_it->second);
+                    // COMPRESSION tag is always SHORT (uint16_t) per TIFF spec
+                    // If it's not, that indicates a bug in nvImageCodec or our parsing
+                    uint16_t compression_value = std::get<uint16_t>(compression_it->second);


Maybe it would be better to directly check if type is correct via https://en.cppreference.com/w/cpp/utility/variant/holds_alternative.html instead of relying on exceptions? But I don't have strong opinions on that, we can leave catch too

thank you for the suggestion @mkepa-nv - this is a good idea and i addressed it in this committ

cdinea · 2025-12-01T18:28:04Z

/ok to test 2716b26

cdinea · 2025-12-01T18:51:10Z

/ok to test c944ffd

cdinea · 2025-12-01T19:18:27Z

/ok to test 7b402de

cdinea · 2025-12-01T20:03:11Z

@KyleFromNVIDIA @jakirkham - The CI is experiencing persistent conda-forge network timeouts.
Could this be a CI runner network/configuration issue?

carterbox · 2025-12-04T21:59:15Z

conda/recipes/libcucim/meta.yaml

    - libnvjpeg
+    - libnvimgcodec0 {{ nvimgcodec_version }}  # nvImageCodec runtime library
  run_constrained:
    - {{ pin_compatible('openslide') }}
+    - libnvimgcodec-dev {{ nvimgcodec_version }}  # Optional: for development/debugging


Suggested change

- libnvjpeg

- libnvimgcodec0 {{ nvimgcodec_version }} # nvImageCodec runtime library

run_constrained:

- {{ pin_compatible('openslide') }}

- libnvimgcodec-dev {{ nvimgcodec_version }} # Optional: for development/debugging

- libnvjpeg

run_constrained:

- {{ pin_compatible('openslide') }}

These constraints aren't necessary. libnvimgcodec-dev has appropriate run_exports, and your constraints are less strict than the run_exports.

cdinea and others added 30 commits November 19, 2025 16:01

refactor: Improve nvImageCodec integration and conda configuration

36e975c

feat: Consolidate nvImageCodec dependencies in dependencies.yaml

b75ba5f

build: Update CMake and build configurations for cuslide2

fc1986b

- Fix libjpeg-turbo cmake configuration for both cuslide and cuslide2 - Update nvimgcodec cmake dependency configuration - Update examples CMakeLists - Update build scripts and documentation

chore: Add PR_DESCRIPTION.md to .gitignore

4c688d8

feat: Add comprehensive nvImageCodec installation verification script

d3e322e

refactor: Remove nvImageCodec plugin implementation references from C…

13670f7

…MakeLists

Add CMake utility modules for cuslide2 plugin

678c40a

fix: Comment out cuslide2_nvimagecodec_test example for infrastructur…

fec4ee5

…e-only PR

build: Add missing CMake dependency files for cuslide2 plugin

e164af8

revert: Remove cuslide2 example from general examples directory

f737c12

revert: Restore original notebook README and clean .gitignore

67a37fe

fix: Disable tests/benchmarks and add missing config file for cuslide2

4486620

Add libnvimgcodec dependencies to dependencies.yaml and regenerate en…

b439403

…vironment files

Use yasm instead of nasm for libjpeg-turbo assembly compilatio

68fc1e2

Add nvImageCodec installation verification script

119de8c

Update pyproject.toml with nvimgcodec dependencies and remove old scr…

405c5fd

…ipt location

Add comprehensive cuslide2 infrastructure verification script

28a2ef9

Refactor verification script and fix build configuration

b0d9634

Add nvImageCodec infrastructure setup for cuslide2

ad0d955

style: Apply SPDX license headers and formatting fixes

60385e0

fixed with ruff per Greg

5f8a8cd

Signed-off-by: cdinea <cdinea@nvidia.com>

added comment detail

543d629

Signed-off-by: cdinea <cdinea@nvidia.com>

fix: Update copyright headers to SPDX format and fix typo

17148e2

Signed-off-by: cdinea <cdinea@nvidia.com>

added comment detail

4514538

Signed-off-by: cdinea <cdinea@nvidia.com>

Update dependencies.yaml

8c594d6

Co-authored-by: jakirkham <jakirkham@gmail.com>

Update dependencies.yaml per john's suuggestion

dd7d107

Co-authored-by: jakirkham <jakirkham@gmail.com>

Update dependencies.yaml per john's suggestion

85dce8e

Co-authored-by: jakirkham <jakirkham@gmail.com>

Update dependencies.yaml per john's suggestion

6076d49

Co-authored-by: jakirkham <jakirkham@gmail.com>

build: Regenerate conda environment files from dependencies.yaml

7bd8d9b

Signed-off-by: cdinea <cdinea@nvidia.com>

build: Fix spacing in pyproject.toml nvidia-nvimgcodec dependency

27acb53

Signed-off-by: cdinea <cdinea@nvidia.com>

mkepa-nv reviewed Nov 27, 2025

View reviewed changes

cdinea added 10 commits November 27, 2025 13:41

fix: Implement proper sub-code stream destruction per nvImageCodec .

a55b1cf

refactor: Remove nvimgcodec_manager.h (singleton moved to nvimgcodec_…

ef12381

…tiff_parser.cpp)

refactor: Extract TIFF tag value extraction to template functions

5a7d785

feat: Add std::monostate to TiffTagValue variant for empty state

e990bb4

fix: Store float/double arrays as vectors for consistency

c0e854f

fix: Remove defensive std::min checks for RATIONAL/SRATIONAL arrays

4921b6e

fix: Make binary TIFF tag size limit configurable

6991a95

fix: Remove dead code with outdated comment

6dd0d47

refactor: Remove tiff_tag_value_to_uint16 helper function.

487852a

python reprducible script

edde6e4

mkepa-nv reviewed Nov 28, 2025

View reviewed changes

cdinea added 2 commits November 28, 2025 10:27

Remove value_stored boolean, use std::monostate check instead

4a0225c

Use std::holds_alternative instead of try-catch for COMPRESSION tag

2716b26

Fix memory allocation mismatch for CPU decoding path

c944ffd

cdinea and others added 2 commits December 1, 2025 11:15

Fix style issues and update dependencies

29e63b7

Merge branch 'release/25.12' into feature/nvimagecodec-v0.7.0

7b402de

cdinea mentioned this pull request Dec 1, 2025

[REVIEW] Feat: PR #1 nvImageCodec infrastructure only #966

Merged

cdinea changed the base branch from release/25.12 to main December 2, 2025 19:54

cdinea removed this from the v25.12.00 milestone Dec 4, 2025

carterbox reviewed Dec 4, 2025

View reviewed changes

cdinea changed the base branch from main to release/25.12 December 4, 2025 23:06

cdinea changed the base branch from release/25.12 to main December 4, 2025 23:08

jakirkham mentioned this pull request Dec 4, 2025

[REVIEW] Feat: PR #2 Add GPU-accelerated TIFF decoding via nvImageCodec v0.6.0 for digital pathology #978

Merged

+                  }
+                  // Store ImageDescription if available from vendor metadata
+                  if (!ifd_info.image_description.empty())

+                      // Convert value based on type and store as typed variant
+                      TiffTagValue tag_value;
+                      bool value_stored = false;

[WIP] PR #3 nvimagecodec v0.7.0 #983

Are you sure you want to change the base?

[WIP] PR #3 nvimagecodec v0.7.0 #983

Uh oh!

Conversation

cdinea commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Update cuslide2 plugin for nvImageCodec v0.7.0

Description

Key Changes

1. CMake Configuration (cmake/deps/nvimgcodec.cmake)

2. API Compatibility Fix (nvimgcodec_decoder.cpp)

3. TIFF Tag Support (nvimgcodec_tiff_parser.cpp)

4. Dependencies (dependencies.yaml)

Related

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cdinea Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cdinea commented Dec 1, 2025

Uh oh!

cdinea commented Dec 1, 2025

Uh oh!

cdinea commented Dec 1, 2025

Uh oh!

cdinea commented Dec 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cdinea commented Nov 26, 2025 •

edited

Loading

1. CMake Configuration (`cmake/deps/nvimgcodec.cmake`)

2. API Compatibility Fix (`nvimgcodec_decoder.cpp`)

3. TIFF Tag Support (`nvimgcodec_tiff_parser.cpp`)

4. Dependencies (`dependencies.yaml`)

cdinea Nov 28, 2025 •

edited

Loading