Rename location.search to location.query_string

Author: Archmonger

src/reactpy/backend/middleware.py

@@ -163,17 +163,17 @@ async def run_dispatcher(
 
             # TODO: Get HTTP URL from `http_pathname` and `http_query_string`
             parsed_url = urllib.parse.urlparse(scope["path"])
+            pathname = parsed_url.path
+            query_string = f"?{parsed_url.query}" if parsed_url.query else ""
 
             await serve_layout(
                 Layout(  # type: ignore
                     ConnectionContext(
                         component(),
                         value=Connection(
                             scope=scope,
-                            # TODO: Rename `search` to `query_string`
                             location=Location(
-                                parsed_url.path,
-                                f"?{parsed_url.query}" if parsed_url.query else "",
+                                pathname=pathname, query_string=query_string
                             ),
                             carrier={
                                 "scope": scope,

src/reactpy/backend/types.py

@@ -35,8 +35,8 @@ class Location:
     pathname: str
     """the path of the URL for the location"""
 
-    search: str
-    """A search or query string - a '?' followed by the parameters of the URL.
+    query_string: str
+    """HTTP query string - a '?' followed by the parameters of the URL.
 
     If there are no search parameters this should be an empty string
     """

tests/test_backend/test_all.py

@@ -124,7 +124,7 @@ def ShowRoute():
         Location("/another/something/file.txt", "?key=value"),
         Location("/another/something/file.txt", "?key1=value1&key2=value2"),
     ]:
-        await display.goto(loc.pathname + loc.search)
+        await display.goto(loc.pathname + loc.query_string)
         await poll_location.until_equals(loc)