Changing theme doesn't immediately change colors in all places

[Luna712]

Steps to reproduce

1. Change theme from dark or light or vice versa
2. Go somewhere like to extensions or the home page in some cases

Expected behavior

The colors should be changed to new theme colors.

Actual behavior

The remain on the old theme colors until, in some cases like the home page, you leave an reenter fragment again, or in other cases until you restart the app entirely.

Cloudstream version and commit hash

4.6.1 6c30af3

Android version

Android 16

Logcat

Other details

No response

Acknowledgements

• I am sure my issue is related to the app and NOT some extension.
• I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
• I have written a short but informative title.
• I have updated the app to pre-release version Latest.
• I will fill out all of the requested information in this form.

[fire-light42]

Looks like our view cache needs to be invalidated.

[Luna712]

@fire-light42 that doesn't seem to have fixed it, at least not for puzzle and github icons in extensions. Haven't confirmed elsewhere yet.

[fire-light42]

@fire-light42 that doesn't seem to have fixed it, at least not for puzzle and github icons in extensions. Haven't confirmed elsewhere yet.

Is this issue also present in the stable release?

[Luna712]

@fire-light42 that doesn't seem to have fixed it, at least not for puzzle and github icons in extensions. Haven't confirmed elsewhere yet.

Is this issue also present in the stable release?

@fire-light42

No it is not an issue on stable for the github icon, as for the puzzle icons I guess those were added recently or something? They don't show up at all on stable.

[fire-light42]

No it is not an issue on stable for the github icon, as for the puzzle icons I guess those were added recently or something? They don't show up at all on stable.

Well, my refactoring fixed an issue with the recyler to properly show icons in case of errors/missing content, so it should be missing on some in stable. However when refactoring I also switched setImageResource to loadImage.

It looks like this issue is not fixed because both CloudStream (and Coil3 apparently) cache aggressively, and the fix was to invalidate the cache CloudStream uses. This means that our loadImage function also needs to be updated.

[Luna712]

Oh that makes a ton of sense thanks.