Merge pull request #167 from oleksandr-danylchenko/fix-two-tap-selection-dismissal

Removed `pointerup`/`pointerdown` events blocking by the `contextmenu` presence

Author: rsimon

packages/text-annotator/src/SelectionHandler.ts

@@ -50,11 +50,7 @@ export const SelectionHandler = (
 
   let lastDownEvent: Selection['event'] | undefined;
 
-  let isContextMenuOpen = false;
-
   const onSelectStart = (evt: Event) => {
-    isContextMenuOpen = false;
-    
     if (isLeftClick === false)
       return;
 
@@ -161,8 +157,6 @@ export const SelectionHandler = (
    * to the initial pointerdown event and remember the button
    */
   const onPointerDown = (evt: PointerEvent) => {
-    if (isContextMenuOpen) return;
-
     if (isNotAnnotatable(evt.target as Node)) return;
 
     /**
@@ -188,8 +182,6 @@ export const SelectionHandler = (
   }
 
   const onPointerUp = (evt: PointerEvent) => {
-    if (isContextMenuOpen) return;
-
     if (isNotAnnotatable(evt.target as Node) || !isLeftClick) return;
 
     // Logic for selecting an existing annotation
@@ -239,8 +231,6 @@ export const SelectionHandler = (
   }
 
   const onContextMenu = (evt: PointerEvent) => {
-    isContextMenuOpen = true;
-
     const sel = document.getSelection();
 
     if (sel?.isCollapsed) return;
@@ -282,15 +272,15 @@ export const SelectionHandler = (
 
         selection.userSelect(currentTarget.annotation, cloneKeyboardEvent(evt));
       }
-      
+
       document.removeEventListener('selectionchange', onSelected);
 
       // Sigh... this needs a delay to work. But doesn't seem reliable.
     }, 100);
 
     // Listen to the change event that follows
     document.addEventListener('selectionchange', onSelected);
-    
+
     // Start selection!
     onSelectStart(evt);
   }