add float support to scalar argument rule

Author: TomasVotruba

rules-tests/CodeQuality/Rector/MethodCall/ScalarArgumentToExpectedParamTypeRector/Fixture/pass_float_to_nullable_string.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\ScalarArgumentToExpectedParamTypeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+use Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\ScalarArgumentToExpectedParamTypeRector\Source\NullableSetter;
+
+final class PassFloatToNullableString extends TestCase
+{
+    public function test()
+    {
+        $nullableSetter = new NullableSetter();
+        $nullableSetter->setMaybe(123.456);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\ScalarArgumentToExpectedParamTypeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+use Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\ScalarArgumentToExpectedParamTypeRector\Source\NullableSetter;
+
+final class PassFloatToNullableString extends TestCase
+{
+    public function test()
+    {
+        $nullableSetter = new NullableSetter();
+        $nullableSetter->setMaybe('123.456');
+    }
+}
+
+?>

rules/CodeQuality/Rector/MethodCall/ScalarArgumentToExpectedParamTypeRector.php

@@ -8,6 +8,7 @@
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Scalar;
+use PhpParser\Node\Scalar\Float_;
 use PhpParser\Node\Scalar\Int_;
 use PhpParser\Node\Scalar\String_;
 use PHPStan\Type\IntegerType;
@@ -114,9 +115,16 @@ public function refactor(Node $node): ?Node
             // remove null
             $knownParameterType = TypeCombinator::removeNull($knownParameterType);
 
-            if ($knownParameterType instanceof StringType && $arg->value instanceof Int_) {
-                $arg->value = new String_((string) $arg->value->value);
-                $hasChanged = true;
+            if ($knownParameterType instanceof StringType) {
+                if ($arg->value instanceof Int_) {
+                    $arg->value = new String_((string) $arg->value->value);
+                    $hasChanged = true;
+                }
+
+                if ($arg->value instanceof Float_) {
+                    $arg->value = new String_((string) $arg->value->value);
+                    $hasChanged = true;
+                }
             }
 
             if ($knownParameterType instanceof IntegerType && $arg->value instanceof String_) {
@@ -159,6 +167,10 @@ private function hasStringOrNumberArguments(StaticCall|MethodCall $call): bool
             if ($arg->value instanceof String_) {
                 return true;
             }
+
+            if ($arg->value instanceof Float_) {
+                return true;
+            }
         }
 
         return false;