addd attribute if msising method

Author: TomasVotruba

rules/PHPUnit120/Rector/Class_/AllowMockObjectsWithoutExpectationsAttributeRector.php

@@ -13,6 +13,8 @@
 use PhpParser\Node\Stmt\ClassMethod;
 use PHPStan\Reflection\ReflectionProvider;
 use Rector\Doctrine\NodeAnalyzer\AttributeFinder;
+use Rector\PhpParser\Node\BetterNodeFinder;
+use Rector\PhpParser\NodeFinder\PropertyFetchFinder;
 use Rector\PHPUnit\Enum\PHPUnitAttribute;
 use Rector\PHPUnit\Enum\PHPUnitClassName;
 use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
@@ -31,7 +33,8 @@ final class AllowMockObjectsWithoutExpectationsAttributeRector extends AbstractR
     public function __construct(
         private readonly TestsNodeAnalyzer $testsNodeAnalyzer,
         private readonly AttributeFinder $attributeFinder,
-        private readonly ReflectionProvider $reflectionProvider
+        private readonly ReflectionProvider $reflectionProvider,
+        private readonly BetterNodeFinder $betterNodeFinder,
     ) {
     }
 
@@ -57,18 +60,29 @@ public function refactor(Node $node): ?Class_
         }
 
         // @todo add the attribute if has more than 1 public test* method
+        $missedTestMethodsByMockPropertyName = [];
         $testMethodCount = 0;
 
-        foreach ($node->getMethods() as $classMethod) {
-            if ($this->testsNodeAnalyzer->isTestClassMethod($classMethod)) {
-                // is a mock property used in the method?
+        foreach ($mockObjectPropertyNames as $mockObjectPropertyName) {
+            $missedTestMethodsByMockPropertyName[$mockObjectPropertyName] = [];
+
+            foreach ($node->getMethods() as $classMethod) {
+                if (! $this->testsNodeAnalyzer->isTestClassMethod($classMethod)) {
+                    continue;
+                }
+
+                // is a mock property used in the class method, as part of some method call? guessing mock expectation is set
                 // skip if so
+                if ($this->isClassMethodUsingMethodCallOnPropertyNamed($classMethod, $mockObjectPropertyName)) {
+                    continue;
+                }
 
+                $missedTestMethodsByMockPropertyName[][] = $this->getName($classMethod);
                 ++$testMethodCount;
             }
         }
 
-        if ($testMethodCount < 2) {
+        if (! $this->shouldAddAttribute($missedTestMethodsByMockPropertyName)) {
             return null;
         }
 
@@ -187,4 +201,38 @@ private function shouldSkipClass(Class_ $class): bool
         $setupClassMethod = $class->getMethod(MethodName::SET_UP);
         return ! $setupClassMethod instanceof ClassMethod;
     }
+
+    private function isClassMethodUsingMethodCallOnPropertyNamed(ClassMethod $classMethod, string $mockObjectPropertyName): bool
+    {
+        /** @var Node\Expr\MethodCall[] $methodCalls */
+        $methodCalls = $this->betterNodeFinder->findInstancesOfScoped([$classMethod], [Node\Expr\MethodCall::class]);
+        foreach ($methodCalls as $methodCall) {
+            if (!$methodCall->var instanceof Node\Expr\PropertyFetch) {
+                continue;
+            }
+
+            $propertyFetch = $methodCall->var;
+
+            // we found a method call on a property fetch named
+            if ($this->isName($propertyFetch, $mockObjectPropertyName)) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
+    private function shouldAddAttribute(array $missedTestMethodsByMockPropertyName): bool
+    {
+        foreach ($missedTestMethodsByMockPropertyName as $propertyName => $missedTestMethods) {
+            // all test methods are using method calls on the mock property, so skip
+            if (count($missedTestMethods) === 0) {
+                continue;
+            }
+
+            return true;
+        }
+
+        return false;
+    }
 }