add fixture

Author: TomasVotruba

rules-tests/PHPUnit120/Rector/Class_/AllowMockObjectsWithoutExpectationsAttributeRector/Fixture/final_property_as_well.php.inc

@@ -0,0 +1,56 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\Class_\AllowMockObjectsWithoutExpectationsAttributeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+use Rector\PHPUnit\Tests\PHPUnit120\Rector\Class_\AllowMockObjectsWithoutExpectationsAttributeRector\Source\SomeFinalClass;
+
+final class FinalPropertyAsWell extends TestCase
+{
+    private \PHPUnit\Framework\MockObject\MockObject $someMock;
+
+    protected function setUp(): void
+    {
+        $this->someMock = $this->createMock(SomeFinalClass::class);
+        $this->someMock->method('some')->willReturn(true);
+    }
+
+    public function testOne()
+    {
+    }
+
+    public function testTwo()
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\Class_\AllowMockObjectsWithoutExpectationsAttributeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+use Rector\PHPUnit\Tests\PHPUnit120\Rector\Class_\AllowMockObjectsWithoutExpectationsAttributeRector\Source\SomeFinalClass;
+
+#[\PHPUnit\Framework\Attributes\AllowMockObjectsWithoutExpectations]
+final class FinalPropertyAsWell extends TestCase
+{
+    private \PHPUnit\Framework\MockObject\MockObject $someMock;
+
+    protected function setUp(): void
+    {
+        $this->someMock = $this->createMock(SomeFinalClass::class);
+        $this->someMock->method('some')->willReturn(true);
+    }
+
+    public function testOne()
+    {
+    }
+
+    public function testTwo()
+    {
+    }
+}
+
+?>

rules-tests/PHPUnit120/Rector/Class_/AllowMockObjectsWithoutExpectationsAttributeRector/Source/SomeFinalClass.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\Class_\AllowMockObjectsWithoutExpectationsAttributeRector\Source;
+
+final class SomeFinalClass
+{
+
+}

rules/PHPUnit120/Rector/Class_/AllowMockObjectsWithoutExpectationsAttributeRector.php

@@ -14,7 +14,6 @@
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassMethod;
 use PHPStan\Reflection\ReflectionProvider;
-use PHPStan\Type\ObjectType;
 use Rector\Doctrine\NodeAnalyzer\AttributeFinder;
 use Rector\PhpParser\Node\BetterNodeFinder;
 use Rector\PHPUnit\Enum\PHPUnitAttribute;
@@ -298,11 +297,9 @@ private function isMissingExpectsOnMockObjectMethodCallInSetUp(Class_ $class): b
                 continue;
             }
 
-            if (! $this->isObjectType($methodCall->var, new ObjectType(PHPUnitClassName::MOCK_OBJECT))) {
-                continue;
+            if ($methodCall->var instanceof Node\Expr\Variable || $methodCall->var instanceof PropertyFetch) {
+                return true;
             }
-
-            return true;
         }
 
         return false;