skip if used in assert call

Author: TomasVotruba

rules/CodeQuality/Rector/ClassMethod/BareCreateMockAssignToDirectUseRector.php

@@ -18,6 +18,7 @@
 use PhpParser\Node\Stmt\Expression;
 use PhpParser\Node\Stmt\Foreach_;
 use Rector\PhpParser\Node\BetterNodeFinder;
+use Rector\PHPUnit\CodeQuality\NodeAnalyser\AssertMethodAnalyzer;
 use Rector\PHPUnit\CodeQuality\NodeAnalyser\AssignedMocksCollector;
 use Rector\PHPUnit\CodeQuality\NodeFinder\VariableFinder;
 use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
@@ -35,6 +36,7 @@ public function __construct(
         private readonly AssignedMocksCollector $assignedMocksCollector,
         private readonly BetterNodeFinder $betterNodeFinder,
         private readonly VariableFinder $variableFinder,
+        private readonly AssertMethodAnalyzer $assertMethodAnalyzer,
     ) {
     }
 
@@ -125,6 +127,10 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
+            if ($this->isUsedInAssertCall($node, $variableName)) {
+                continue;
+            }
+
             // 1. remove initial assign
             $variablesToMethodCalls = [];
 
@@ -251,4 +257,34 @@ private function isUsedInClosure(ClassMethod|Foreach_ $stmtsAware, string $varia
 
         return false;
     }
+
+    private function isUsedInAssertCall(ClassMethod|Foreach_ $stmtsAware, string $variableName): bool
+    {
+        /** @var StaticCall[]|MethodCall[] $calls */
+        $calls = $this->betterNodeFinder->findInstancesOfScoped([$stmtsAware], [MethodCall::class, StaticCall::class]);
+
+        $assertCalls = [];
+        foreach ($calls as $call) {
+            if (! $this->assertMethodAnalyzer->detectTestCaseCall($call)) {
+                continue;
+            }
+
+            $assertCalls[] = $call;
+        }
+
+        foreach ($assertCalls as $assertCall) {
+            foreach ($assertCall->getArgs() as $assertCallArg) {
+                if (! $assertCallArg->value instanceof Variable) {
+                    continue;
+                }
+
+                if ($this->isName($assertCallArg->value, $variableName)) {
+                    return true;
+                }
+
+            }
+        }
+
+        return false;
+    }
 }