[CodeQuality] Skip assertEquals() on integer to numeric string on MatchAssertSameExpectedTypeRector (#522)

Author: samsonasik

rules/CodeQuality/Rector/MethodCall/MatchAssertSameExpectedTypeRector.php

@@ -36,7 +36,7 @@ public function getRuleDefinition(): RuleDefinition
 
 class SomeTest extends TestCase
 {
-    public function run()
+    public function test()
     {
         $this->assertSame('123', $this->getOrderId());
     }
@@ -53,7 +53,7 @@ private function getOrderId(): int
 
 class SomeTest extends TestCase
 {
-    public function run()
+    public function test()
     {
         $this->assertSame(123, $this->getOrderId());
     }
@@ -115,6 +115,10 @@ public function refactor(Node $node): ?Node
         }
 
         if ($expectedType->isInteger()->yes() && $directVariableType->isString()->yes()) {
+            if ($this->isName($node->name, 'assertEquals')) {
+                return null;
+            }
+
             // update expected type to provided type
             $expectedArg->value = new String_((string) $expectedArg->value->value);
 

tests/Issues/AssertEqualsSame/Fixture/assert_equals_numeric_string.php.inc

@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPUnit\Tests\Issues\AssertEqualsSame;
+
+use PHPUnit\Framework\TestCase;
+
+class SkipAssertEqualsIntegerToString extends TestCase
+{
+    public function test()
+    {
+        $this->assertEquals(123, $this->getOrderId());
+    }
+
+    private function getOrderId(): string
+    {
+        return '0000000000000000000123';
+    }
+}