[CodeQuality] Skip Generator on AssertCompareOnCountableWithMethodToAssertCountRector

Author: samsonasik

rules-tests/CodeQuality/Rector/MethodCall/AssertCompareOnCountableWithMethodToAssertCountRector/Fixture/skip_generator.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertCompareOnCountableWithMethodToAssertCountRector\Fixture;
+
+final class SkipGenerator extends \PHPUnit\Framework\TestCase
+{
+    public function test()
+    {
+        $executedProcesses = $this->get();
+        $this->assertSame(10, iterator_count($executedProcesses));
+    }
+
+    private function get(): \Generator
+    {
+        for ($i = 0; $i < 10; $i++) {
+            yield $i;
+        }
+    }
+}

rules/CodeQuality/Rector/MethodCall/AssertCompareOnCountableWithMethodToAssertCountRector.php

@@ -84,6 +84,11 @@ public function refactor(Node $node): MethodCall|StaticCall|null
             && $this->isNames($comparedExpr->name, ['count', 'sizeof', 'iterator_count'])
         ) {
             $countArg = $comparedExpr->getArgs()[0];
+
+            if ($this->isObjectType($countArg->value, new ObjectType('Generator'))) {
+                return null;
+            }
+
             $assertArgs[1] = new Arg($countArg->value);
 
             $node->args = $assertArgs;