Fix ParamTypeByMethodCallTypeRector (#6803)

carlos-granados · web-flow · commit 9939bd2a7e9d · 2025-03-21T16:44:07.000+07:00
diff --git a/rules/TypeDeclaration/Rector/ClassMethod/ParamTypeByMethodCallTypeRector.php b/rules/TypeDeclaration/Rector/ClassMethod/ParamTypeByMethodCallTypeRector.php
@@ -189,7 +189,6 @@ private function refactorClassMethod(ClassMethod $classMethod, array $callers, S
                 }
 
                 $paramTypes[] = $this->phpParserNodeMapper->mapToPHPStanType($paramType);
-                $hasChanged = true;
             }
 
             if ($paramTypes === []) {
@@ -201,6 +200,7 @@ private function refactorClassMethod(ClassMethod $classMethod, array $callers, S
 
             if ($paramNodeType instanceof Node) {
                 $param->type = $paramNodeType;
+                $hasChanged = true;
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,6 @@ private function refactorClassMethod(ClassMethod $classMethod, array $callers, S`
`189`	`189`	`}`
`190`	`190`
`191`	`191`	`$paramTypes[] = $this->phpParserNodeMapper->mapToPHPStanType($paramType);`
`192`		`- $hasChanged = true;`
`193`	`192`	`}`
`194`	`193`
`195`	`194`	`if ($paramTypes === []) {`
`@@ -201,6 +200,7 @@ private function refactorClassMethod(ClassMethod $classMethod, array $callers, S`
`201`	`200`
`202`	`201`	`if ($paramNodeType instanceof Node) {`
`203`	`202`	`$param->type = $paramNodeType;`
	`203`	`+ $hasChanged = true;`
`204`	`204`	`}`
`205`	`205`	`}`
`206`	`206`