chore: fix tests

Signed-off-by: Stephane Bouchet <sbouchet@redhat.com>

Author: sbouchet

src/test/java/com/redhat/devtools/intellij/MavenModuleImportingTestCase.java

@@ -40,8 +40,8 @@ protected void setUpFixtures() throws Exception {
     final JavaTestFixtureFactory factory = JavaTestFixtureFactory.getFixtureFactory();
     myProjectBuilder.addModule(JavaModuleFixtureBuilder.class);
     IdeaProjectTestFixture myFixture = factory.createCodeInsightFixture(myProjectBuilder.getFixture());
-    myFixture.setUp();
     setTestFixture(myFixture);
+    myFixture.setUp();
     LanguageLevelProjectExtension.getInstance(myFixture.getProject()).setLanguageLevel(LanguageLevel.JDK_17);
   }
 
@@ -70,9 +70,16 @@ protected List<Module> createMavenModules(List<File> projectDirs) throws Excepti
     for(Module module : modules) {
       setupJdkForModule(module.getName());
     }
+
     // Starting from IntelliJ 2024.2, indexing runs asynchronously in a background thread, https://plugins.jetbrains.com/docs/intellij/testing-faq.html#how-to-handle-indexing.
     // Use the following method to ensure indexes are fully populated before proceeding.
     IndexingTestUtil.waitUntilIndexesAreReady(project);
+    // REVISIT: After calling setupJdkForModule() initialization appears to continue in the background
+    // and a may cause a test to intermittently fail if it accesses the module too early. A 5-second wait
+    // is hopefully long enough but would be preferable to synchronize on a completion event if one is
+    // ever introduced in the future.
+    Thread.sleep(5000L);
+
     return Arrays.stream(modules).skip(1).toList();
   }
 
@@ -104,6 +111,6 @@ protected Module createMavenModule(String name, String xml) throws Exception {
   }
 
   protected IPsiUtils getJDTUtils() {
-    return PsiUtilsLSImpl.getInstance(getTestFixture().getProject());
+    return PsiUtilsLSImpl.getInstance(getProject());
   }
 }

src/test/java/com/redhat/devtools/intellij/lsp4mp4ij/psi/core/PropertiesManagerLocationTest.java

@@ -10,7 +10,6 @@
 package com.redhat.devtools.intellij.lsp4mp4ij.psi.core;
 
 import com.intellij.openapi.module.Module;
-import com.redhat.devtools.intellij.MavenModuleImportingTestCase;
 import com.redhat.devtools.intellij.lsp4mp4ij.psi.internal.core.ls.PsiUtilsLSImpl;
 import org.eclipse.lsp4j.Location;
 import org.junit.Assert;

src/test/java/com/redhat/devtools/intellij/lsp4mp4ij/psi/core/config/properties/MicroProfileConfigPropertyTest.java

@@ -42,7 +42,7 @@ public void testConfigQuickstartFromClasspath() throws Exception {
         File f = MavenArtifactUtil.getArtifactFile(myProjectsManager.findProject(module).getLocalRepository(), new MavenId("io.quarkus:quarkus-core-deployment:1.1.0.Final"), "jar").toFile();
         assertNotNull("Test existing of quarkus-core-deployment*.jar", f);
 
-        assertProperties(infoFromClasspath, 244 /* properties from JAR */ + //
+        assertProperties(infoFromClasspath, 240 /* properties from JAR */ + //
                         31 /* properties from Java sources with ConfigProperty */ + //
                         2 /* properties from Java sources with ConfigRoot */ + //
                         7 /* static properties from microprofile-context-propagation-api */ +