VMNO: Enable user variable for enabling or disabling secondary disk

[venkataanil]

For VMNO deployments, secondary disk is mandatorily set by ansible tasks during inventory creation based on server type. I got "x37-h33-000-r740xd " as part of my allocation but has only one disk.

[root@x37-h33-000-r740xd ~]# lsblk
NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINTS
sda 8:0 0 1.6T 0 disk
├─sda1 8:1 0 1G 0 part /boot
└─sda2 8:2 0 1.6T 0 part
├─rhel_x37--h33--000--r740xd-root 253:0 0 70G 0 lvm /
└─rhel_x37--h33--000--r740xd-swap 253:1 0 4G 0 lvm [SWAP]

Because of this, ansible/hv-setup.yml ansible playbook is failing

TASK [hv-setup-disk2 : Create disk2 primary partition] *************************
task path: /root/jetlag/ansible/roles/hv-setup-disk2/tasks/main.yml:4
<x37-h33-000-r740xd.rdu3.labs.perfscale.redhat.com> (0, b'', b'')
fatal: [x37-h33-000-r740xd.rdu3.labs.perfscale.redhat.com]: FAILED! => {
"changed": false,
"err": "Error: Could not stat device /dev/nvme0n1 - No such file or directory.\n",
"invocation": {
"module_args": {
"align": "optimal",
"device": "/dev/nvme0n1",
"flags": null,
"fs_type": null,
"label": "gpt",
"name": null,
"number": 1,
"part_end": "100%",
"part_start": "0%",
"part_type": "primary",
"resize": false,
"state": "present",
"unit": "KiB"
}
},
"msg": "Error while getting device information with parted script: '/usr/sbin/parted -s -m /dev/nvme0n1 -- unit 'KiB' print'",
"out": "",
"rc": 1
}

As a tempory workaround, in the created inventory file, I have removed

1. secondary disk
2. VMs which will be using the secondary disk

However we need a proper solution for this.

[afcollins]

I see a disk2_enable variable. Is that enough?

Just one random instance of the variable in use: https://github.com/redhat-performance/jetlag/blob/main/ansible/roles/create-inventory/templates/inventory-mno.j2#L94