Enabled to specify profile frequency and mode on profiler logic (#347)

Author: filipecosta90

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "redisbench-admin"
-version = "0.8.3"
+version = "0.8.4"
 description = "Redis benchmark run helper. A wrapper around Redis and Redis Modules benchmark tools ( ftsb_redisearch, memtier_benchmark, redis-benchmark, aibench, etc... )."
 authors = ["filipecosta90 <filipecosta.90@gmail.com>","Redis Performance Group <performance@redis.com>"]
 readme = "README.md"

redisbench_admin/profilers/profilers_local.py

@@ -20,7 +20,7 @@
 
 
 def profilers_stop_if_required(
-    args,
+    upload_results_s3,
     benchmark_duration_seconds,
     collection_summary_str,
     dso,
@@ -121,7 +121,7 @@ def profilers_stop_if_required(
             profile_artifact,
         ) in overall_artifacts_map.items():
             s3_link = None
-            if args.upload_results_s3:
+            if upload_results_s3:
                 logging.info(
                     "Uploading results to s3. s3 bucket name: {}. s3 bucket path: {}".format(
                         s3_bucket_name, s3_bucket_path
@@ -152,6 +152,8 @@ def profilers_start_if_required(
     setup_name,
     start_time_str,
     test_name,
+    profiler_frequency=99,
+    profiler_call_graph_mode="fp",
 ):
     profilers_map = {}
     profiler_name = None
@@ -197,7 +199,8 @@ def profilers_start_if_required(
                 profiler_obj.start_profile(
                     redis_process_pid,
                     profile_filename,
-                    PROFILE_FREQ,
+                    profiler_frequency,
+                    profiler_call_graph_mode,
                 )
     return profiler_name, profilers_map
 

redisbench_admin/run_local/run_local.py

@@ -13,9 +13,11 @@
 import redis
 
 import redisbench_admin.run.metrics
+from redisbench_admin.profilers.perf import PERF_CALLGRAPH_MODE
 from redisbench_admin.profilers.profilers_schema import (
     local_profilers_print_artifacts_table,
 )
+from redisbench_admin.run.args import PROFILE_FREQ
 from redisbench_admin.run.common import (
     prepare_benchmark_parameters,
     get_start_time_vars,
@@ -279,6 +281,8 @@ def run_local_command_logic(args, project_name, project_version):
                                     setup_name,
                                     start_time_str,
                                     test_name,
+                                    PROFILE_FREQ,
+                                    PERF_CALLGRAPH_MODE,
                                 )
 
                                 # run the benchmark
@@ -329,7 +333,7 @@ def run_local_command_logic(args, project_name, project_version):
                                     _,
                                     overall_tabular_data_map,
                                 ) = profilers_stop_if_required(
-                                    args,
+                                    args.upload_results_s3,
                                     benchmark_duration_seconds,
                                     collection_summary_str,
                                     dso,