refactor: steps to parse reply for several commands in bootstrap (#202)

Author: supercaracal

lib/redis_client/cluster/command.rb

@@ -10,6 +10,7 @@ class Command
       EMPTY_STRING = ''
       LEFT_BRACKET = '{'
       RIGHT_BRACKET = '}'
+      EMPTY_HASH = {}.freeze
 
       Detail = Struct.new(
         'RedisCommand',
@@ -41,16 +42,15 @@ def load(nodes)
         private
 
         def parse_command_reply(rows)
-          rows&.reject { |row| row[0].nil? }.to_h do |row|
-            [
-              row[0].downcase,
-              ::RedisClient::Cluster::Command::Detail.new(
-                first_key_position: row[3],
-                write?: row[2].include?('write'),
-                readonly?: row[2].include?('readonly')
-              )
-            ]
-          end
+          rows&.each_with_object({}) do |row, acc|
+            next if row[0].nil?
+
+            acc[row[0].downcase] = ::RedisClient::Cluster::Command::Detail.new(
+              first_key_position: row[3],
+              write?: row[2].include?('write'),
+              readonly?: row[2].include?('readonly')
+            )
+          end || EMPTY_HASH
         end
       end
 

lib/redis_client/cluster/node.rb

@@ -135,7 +135,7 @@ def load_info(options, **kwargs) # rubocop:disable Metrics/AbcSize, Metrics/Cycl
         # @see https://redis.io/commands/cluster-nodes/
         # @see https://github.com/redis/redis/blob/78960ad57b8a5e6af743d789ed8fd767e37d42b8/src/cluster.c#L4660-L4683
         def parse_cluster_node_reply(reply) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
-          reply.each_line("\n", chomp: true).with_object(Array.new(reply.count("\n"))) do |line, acc|
+          reply.each_line("\n", chomp: true).filter_map do |line|
             fields = line.split
             flags = fields[2].split(',')
             next unless fields[7] == 'connected' && (flags & DEAD_FLAGS).empty?
@@ -149,7 +149,7 @@ def parse_cluster_node_reply(reply) # rubocop:disable Metrics/AbcSize, Metrics/C
                                  .map(&:sort)
                     end
 
-            acc << ::RedisClient::Cluster::Node::Info.new(
+            ::RedisClient::Cluster::Node::Info.new(
               id: fields[0],
               node_key: fields[1].split('@').first,
               role: (flags & ROLE_FLAGS).first,
@@ -160,7 +160,7 @@ def parse_cluster_node_reply(reply) # rubocop:disable Metrics/AbcSize, Metrics/C
               link_state: fields[7],
               slots: slots
             )
-          end.compact
+          end
         end
       end