Fix documents and refactoring (#63)

Author: supercaracal

docs/CLASS_DIAGRAMS.md docs/class_diagrams_redis_client.mddocs/CLASS_DIAGRAMS.md renamed to docs/class_diagrams_redis_client.md

@@ -0,0 +1,101 @@
+# RedisClient::Cluster
+
+```mermaid
+classDiagram
+  class RedisClient_Cluster {
+    +inspect()
+    +call()
+    +call_once()
+    +blocking_call()
+    +scan()
+    +sscan()
+    +hscan()
+    +zscan()
+    +pipelined()
+    +pubsub()
+    +close()
+  }
+
+  class RedisClient_ClusterConfig {
+    +inspect()
+    +new_pool()
+    +new_client()
+    +per_node_key()
+    +use_replica?()
+    +update_node()
+    +add_node()
+    +dup()
+  }
+
+  class RedisClient_Cluster_Command {
+    +self.load()
+    +extract_first_key()
+    +should_send_to_primary?()
+    +should_send_to_replica?()
+  }
+
+  class module_RedisClient_Cluster_KeySlotConverter {
+    +convert()
+  }
+
+  class RedisClient_Cluster_Node {
+    +self.load_info()
+    +inspect()
+    +each()
+    +sample()
+    +node_keys()
+    +primary_node_keys()
+    +replica_node_keys()
+    +find_by()
+    +call_all()
+    +call_primaries()
+    +call_replicas()
+    +send_ping()
+    +scale_reading_clients()
+    +find_node_key_of_primary()
+    +find_node_key_of_replica()
+    +update_slot()
+    +replicated?()
+  }
+
+  class module_RedisClient_Cluster_NodeKey {
+    +hashify()
+    +split()
+    +build_from_uri()
+    +build_from_host_port()
+  }
+
+  class RedisClient_Cluster_Pipeline {
+    +call()
+    +call_once()
+    +blocking_call()
+    +empty?()
+    +execute()
+  }
+
+  class RedisClient_Cluster_PubSub {
+    +call()
+    +close()
+    +next_event()
+  }
+
+  class RedisClient_Cluster_Router {
+    +send_command()
+    +try_send()
+    +scan()
+    +assign_node()
+    +find_node_key()
+    +find_node()
+  }
+
+  RedisClient_ClusterConfig ..> RedisClient_Cluster : new
+
+  RedisClient_Cluster ..> RedisClient_Cluster_Pipeline : new
+  RedisClient_Cluster ..> RedisClient_Cluster_PubSub : new
+  RedisClient_Cluster ..> RedisClient_Cluster_Router : new
+
+  RedisClient_Cluster_Router ..> RedisClient_Cluster_Node : new
+  RedisClient_Cluster_Router ..> RedisClient_Cluster_Command : new
+  RedisClient_Cluster_Router ..> module_RedisClient_Cluster_KeySlotConverter : call
+  RedisClient_Cluster_Router ..> module_RedisClient_Cluster_NodeKey : call
+```

docs/class_diagrams_redis_cluster_client.md

@@ -2,16 +2,12 @@
 
 require 'redis_client'
 require 'redis_client/cluster/pipeline'
-require 'redis_client/cluster/pubsub'
+require 'redis_client/cluster/pub_sub'
 require 'redis_client/cluster/router'
 
 class RedisClient
   class Cluster
     ZERO_CURSOR_FOR_SCAN = '0'
-    CMD_SCAN = 'SCAN'
-    CMD_SSCAN = 'SSCAN'
-    CMD_HSCAN = 'HSCAN'
-    CMD_ZSCAN = 'ZSCAN'
 
     def initialize(config, pool: nil, **kwargs)
       @router = ::RedisClient::Cluster::Router.new(config, pool: pool, **kwargs)
@@ -38,24 +34,24 @@ def scan(*args, **kwargs, &block)
 
       cursor = ZERO_CURSOR_FOR_SCAN
       loop do
-        cursor, keys = @router.scan(CMD_SCAN, cursor, *args, **kwargs)
+        cursor, keys = @router.scan('SCAN', cursor, *args, **kwargs)
         keys.each(&block)
         break if cursor == ZERO_CURSOR_FOR_SCAN
       end
     end
 
     def sscan(key, *args, **kwargs, &block)
-      node = @router.assign_node(CMD_SSCAN, key)
+      node = @router.assign_node('SSCAN', key)
       @router.try_send(node, :sscan, key, *args, **kwargs, &block)
     end
 
     def hscan(key, *args, **kwargs, &block)
-      node = @router.assign_node(CMD_HSCAN, key)
+      node = @router.assign_node('HSCAN', key)
       @router.try_send(node, :hscan, key, *args, **kwargs, &block)
     end
 
     def zscan(key, *args, **kwargs, &block)
-      node = @router.assign_node(CMD_ZSCAN, key)
+      node = @router.assign_node('ZSCAN', key)
       @router.try_send(node, :zscan, key, *args, **kwargs, &block)
     end
 

docs/CLOUD_SERVICES.md docs/cloud_services.mddocs/CLOUD_SERVICES.md renamed to docs/cloud_services.md

@@ -11,10 +11,6 @@ class RedisClient
   class Cluster
     class Router
       ZERO_CURSOR_FOR_SCAN = '0'
-      CMD_ASKING = 'ASKING'
-      REPLY_OK = 'OK'
-      REPLY_MOVED = 'MOVED'
-      REPLY_ASK = 'ASK'
 
       attr_reader :node
 
@@ -69,13 +65,13 @@ def try_send(node, method, *args, retry_count: 3, **kwargs, &block) # rubocop:di
       rescue ::RedisClient::CommandError => e
         raise if retry_count <= 0
 
-        if e.message.start_with?(REPLY_MOVED)
+        if e.message.start_with?('MOVED')
           node = assign_redirection_node(e.message)
           retry_count -= 1
           retry
-        elsif e.message.start_with?(REPLY_ASK)
+        elsif e.message.start_with?('ASK')
           node = assign_asking_node(e.message)
-          node.call(CMD_ASKING)
+          node.call('ASKING')
           retry_count -= 1
           retry
         else