Distinguish network responses from their redirects. #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For #RUN-2343 (https://linear.app/replay/issue/RUN-2343/the-network-monitor-should-show-the-response-url) Network requests that are redirected currently emit duplicate network request events with the id of the original request. Disitinguish between these by assigning them a different id. However, take care to ensure that bookmarks, which are tracked by the underlying "umbrella request id", are properly registered with each network request in the redirect chain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #RUN-2343 (https://linear.app/replay/issue/RUN-2343/the-network-monitor-should-show-the-response-url)
Network requests that are redirected currently emit duplicate network request events with the id of the original request.
Disitinguish between these by assigning them a different id.
However, take care to ensure that bookmarks, which are tracked by the underlying "umbrella request id", are properly registered with each network request in the redirect chain.