Skip to content

Commit 3825bc2

Browse files
use button tag instead of div with role button
1 parent 83d6ea1 commit 3825bc2

File tree

6 files changed

+14
-18
lines changed

6 files changed

+14
-18
lines changed

app/src/pages/inside/productVersionPage/linkedTestCasesTab/filterBlock/filterBlock.jsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,7 @@ export const FilterBlock = ({ filters, clearAllFilters }) => {
3535
{filters.status && (
3636
<div className={cx('filter-block__status')}>
3737
{filters.status}
38-
<div
39-
role="button"
40-
tabIndex={0}
41-
aria-label="Close button"
38+
<button
4239
className={cx('filter-block__status-icon')}
4340
onClick={clearAllFilters}
4441
onKeyDown={(e) => {
@@ -48,7 +45,7 @@ export const FilterBlock = ({ filters, clearAllFilters }) => {
4845
}}
4946
>
5047
<CloseIcon />
51-
</div>
48+
</button>
5249
</div>
5350
)}
5451
<Button className={cx('filter-block__add-button')} icon={<PlusIcon />} variant="text">

app/src/pages/inside/productVersionPage/linkedTestCasesTab/filterBlock/filterBlock.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@
4343
align-items: center;
4444
width: 16px;
4545
height: 16px;
46+
padding: 0;
47+
border-width: 0;
48+
background-color: transparent;
4649
cursor: pointer;
4750

4851
svg {

app/src/pages/inside/productVersionPage/linkedTestCasesTab/headerConfig/headerConfig.jsx

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -136,12 +136,7 @@ export const HeaderConfig = ({ filters, setFilters }) => {
136136
setIsOpened={setIsMainFilterOpen}
137137
aria-label="Filter settings"
138138
>
139-
<div
140-
role="button"
141-
tabIndex={0}
142-
aria-haspopup="true"
143-
aria-expanded={isMainFilterOpen}
144-
aria-label="Filter icon"
139+
<button
145140
className={cx('filters-icon-container', {
146141
'with-applied': appliedFiltersCount,
147142
opened: isMainFilterOpen,
@@ -157,7 +152,7 @@ export const HeaderConfig = ({ filters, setFilters }) => {
157152
{appliedFiltersCount ? (
158153
<span className={cx('filters-count')}>{appliedFiltersCount}</span>
159154
) : null}
160-
</div>
155+
</button>
161156
</Popover>
162157
</div>
163158
<div className={cx('header-config__toggle')}>

app/src/pages/inside/productVersionPage/linkedTestCasesTab/headerConfig/headerConfig.scss

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
background-color: inherit;
3030

3131
&:hover {
32-
background-color: inherit;
32+
background-color: inherit !important;
3333
}
3434
}
3535

@@ -43,6 +43,9 @@
4343
justify-content: center;
4444
width: 57px;
4545
border-radius: 20px;
46+
border-width: 0;
47+
background-color: transparent;
48+
cursor: pointer;
4649

4750
&:focus-visible {
4851
outline: 2px solid var(--rp-ui-base-dark-topaz-main);

app/src/pages/inside/productVersionPage/linkedTestCasesTab/tagList/tagList.jsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -100,16 +100,13 @@ export const TagList = ({ tags }) => {
100100
)}
101101
</div>
102102
{isCounterButtonVisible ? (
103-
<div
104-
role="button"
105-
tabIndex={0}
106-
aria-label="Counter button"
103+
<button
107104
className={cx('tag-list__item', 'tag-list__item--count')}
108105
onClick={toggleExpanded}
109106
onKeyDown={handleKeyDown}
110107
>
111108
+{count}
112-
</div>
109+
</button>
113110
) : null}
114111
</div>
115112
);

app/src/pages/inside/productVersionPage/linkedTestCasesTab/tagList/tagList.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@
7777
padding-right: 7px;
7878
overflow: visible;
7979
cursor: pointer;
80+
background-color: transparent;
8081
color: var(--rp-ui-base-e-400);
8182
}
8283
}

0 commit comments

Comments
 (0)