From fb91454d31e5a7da26138b178828028695f83e41 Mon Sep 17 00:00:00 2001 From: Max Shmelev Date: Sun, 17 Jan 2016 21:56:27 -0500 Subject: [PATCH 1/3] Fix options usage Now options are passed as Options object (with 'store' in it), but used as a simple object (see roundRobinSort, which can't find options.roundRobinSize, and roundRobin logic is never applied). This fix converts Options-typed object o a simple object. --- lib/servers.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/servers.js b/lib/servers.js index 8dfc2fa..a6dc7df 100644 --- a/lib/servers.js +++ b/lib/servers.js @@ -50,6 +50,8 @@ Servers.prototype.resetStats = function () { } Servers.prototype.sort = function (operation, options) { + if (options) + options = options.get(); var servers = this.servers.slice(0) if (servers.length > 1) { servers.sort(function (x, y) { From 52a249e945c0dc1add8d331e7aa3c5bf3470522a Mon Sep 17 00:00:00 2001 From: Max Shmelev Date: Sun, 17 Jan 2016 22:05:52 -0500 Subject: [PATCH 2/3] Correct JS style --- lib/servers.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/servers.js b/lib/servers.js index a6dc7df..88c061e 100644 --- a/lib/servers.js +++ b/lib/servers.js @@ -50,8 +50,9 @@ Servers.prototype.resetStats = function () { } Servers.prototype.sort = function (operation, options) { - if (options) + if (options) { options = options.get(); + } var servers = this.servers.slice(0) if (servers.length > 1) { servers.sort(function (x, y) { From 6bb4c78e925e44704534161eb2e0ddb37839f55b Mon Sep 17 00:00:00 2001 From: Max Shmelev Date: Sun, 17 Jan 2016 22:10:26 -0500 Subject: [PATCH 3/3] Correct JS style --- lib/servers.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/servers.js b/lib/servers.js index 88c061e..d2fd4cf 100644 --- a/lib/servers.js +++ b/lib/servers.js @@ -51,7 +51,7 @@ Servers.prototype.resetStats = function () { Servers.prototype.sort = function (operation, options) { if (options) { - options = options.get(); + options = options.get() } var servers = this.servers.slice(0) if (servers.length > 1) {