Skip to content

Conversation

@lobis
Copy link
Member

@lobis lobis commented Aug 8, 2023

@lobis lobis linked an issue Aug 8, 2023 that may be closed by this pull request
@lobis lobis added the enhancement New feature or request label Aug 8, 2023
@lobis lobis requested review from jgalan and juanangp August 8, 2023 16:32
@lobis
Copy link
Member Author

lobis commented Aug 8, 2023

@jgalan @juanangp let me know if you are okay with this, so far it looks like it does not break anything except some processes in connectorslib that are easy to fix.

@juanangp
Copy link
Member

juanangp commented Aug 8, 2023

@jgalan @juanangp let me know if you are okay with this, so far it looks like it does not break anything except some processes in connectorslib that are easy to fix.

I have nothing against this implementation, but perhaps it breaks backward compatibility, would be good to check that as well.

@lobis
Copy link
Member Author

lobis commented Aug 8, 2023

@jgalan @juanangp let me know if you are okay with this, so far it looks like it does not break anything except some processes in connectorslib that are easy to fix.

I have nothing against this implementation, but perhaps it breaks backward compatibility, would be good to check that as well.

It probably breaks backwards compatibility yes, but so does many changes we do, so I think we should not rule it out because of this. Maybe we should include this on a large release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TRestRawSignal should use unsigned short instead of signed short

3 participants