Skip to content

Conversation

@everyonce
Copy link

No description provided.

@ebenoist
Copy link
Contributor

ebenoist commented Nov 23, 2016

@everyonce Thank you for the PR! Would you mind adding a test or two to cover the new behavior? I also think you might be able to use Go's built in Url parser to get the User, Host, and Password without needing to use any splits or Contains checks.

https://golang.org/pkg/net/url/#Parse

I wrote a small example up here: https://play.golang.org/p/0soC3LO111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants