E21: Cannot make changes, 'modifiable' is off

[sunaku]

I have been getting this error after upgrading recently:

"~/.git/COMMIT_EDITMSG" 106L, 1744C
Error detected while processing function committia#open..<SNR>225_open_singlecolumn..<SNR>225_open_diff_window..<SNR>225_open_window:
line    8:
Error detected while processing function committia#open..<SNR>225_open_multicolumn..<SNR>225_remove_all_contents_except_for_commit_message:
line    4:
E21: Cannot make changes, 'modifiable' is off
Press ENTER or type command to continue

Thanks. 👼

[rhysd]

I can't reproduce. Could you tell me your configuration of committia.vim and show me the way to reproduce?

I guess you may already open commit buffer anywhere.

[sunaku]

Sorry, you are correct. I deleted my ~/.vimrc file, checked out this repository to ~/.vim, and observed that the problem no longer occurs. 😱 Sorry for the confusion. 😕

[sunaku]

I found that the vim-diff-enhanced plugin was causing the problem! Removing it makes this plugin work correctly again. ✨

[rgrinberg]

Would be great to have a workaround for this as I really like the enhanced diff plugin.

[rhysd]

@sunaku

Thank you for your investigation. It seems that this plugin has a collision with vim-diff-enhanced. I'll investigate the reason.

[rhysd]

@sunaku @rgrinberg

I couldn't reproduce the error although I installed vim-diff-enhanced. But I added a change to set unmodified before setting filetype on the basis of @sunaku's error log. Could you update committia.vim and try it with vim-diff-enhanced?
If it doesn't still work, please let me know the way to reproduce the error.

[sunaku]

@rhysd The problem occurs when source vim-diff-enhanced/plugin/EnhancedDiff.vim is executed before this plugin gets a chance to do its job. For example, this happens when I have vim-diff-enhanced installed as a "ftbundle" or filetype-specific bundle (whereby it is essentially autocmd FileType * source vim-diff-enhanced/plugin/EnhancedDiff.vim set up to run when the diff filetype is first loaded). 😅

[rafi]

I'm receiving this error too, but I'm not using vim-diff-enhanced.

Error detected while processing function committia#open..<SNR>103_open_singlecolumn..<SNR>103_open_diff_w
indow..<SNR>103_open_window:
line    8:
E21: Cannot make changes, 'modifiable' is off

[rhysd]

I couldn't reproduce this. Could you please tell me the situation more?

• What command? git commit? git commit --amend? git rebase?
• OS

I will try to add workaround for this.

[rafi]

• Command: git commit, or git commit --amend
• OSX 10.11.3
• Git 2.7.1

[rhysd]

OK, thanks.