-
Notifications
You must be signed in to change notification settings - Fork 64
Open
Description
Description
The codebase currently references the Claude ACP agent process using the outdated name claude-code-acp, but the latest package has been renamed to claude-agent-acp. This affects both the npm package reference and internal identifiers.
Current State
The following locations use the old naming:
-
NPM package reference (agents.rs:609):
let package = fallback_npx_package( "@zed-industries/claude-code-acp", options.agent_process_version.as_deref(), );
-
Agent process registry ID (agents.rs:81):
AgentId::Claude => Some("claude-code-acp"),
-
Agent process binary hint (agents.rs:93):
AgentId::Claude => Some("claude-code-acp"),
-
Documentation references:
research/acp/spec.md:170research/acp/acp-notes.md:59research/agents/claude.md:18
Expected State
All references should be updated to use claude-agent-acp:
- NPM package:
@zed-industries/claude-agent-acp - Registry ID:
claude-agent-acp - Binary hint:
claude-agent-acp - Documentation: Updated to reflect the new name
Impact
This naming mismatch may cause:
- Agent installation failures when using the outdated package name
- Confusion for developers working with the codebase
- Potential runtime errors if the old package is deprecated or removed
Proposed Solution
- Update the npm package reference in
server/packages/agent-management/src/agents.rs:609 - Update
agent_process_registry_idreturn value forAgentId::Claude - Update
agent_process_binary_hintreturn value forAgentId::Claude - Update all documentation references to use the new naming
- Consider adding a deprecation notice or migration guide if needed
Additional Context
The correct package name @zed-industries/claude-agent-acp aligns with the naming convention used by other agents in the system (e.g., cursor-agent-acp).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels