-
-
Notifications
You must be signed in to change notification settings - Fork 37
Maintenance #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Maintenance #145
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b5fedc0
Add CS fixer CI workflow
roxblnfk 1d6b420
Update metafiles
roxblnfk 39d328e
First Readme fix iteration
roxblnfk d191d58
Second Readme fix iteration
roxblnfk e4525f8
Third Readme fix iteration
roxblnfk af87a04
Fourth Readme fix iteration
roxblnfk 23ca5a0
Simplify docs
roxblnfk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| * text=auto | ||
|
|
||
| /.github export-ignore | ||
| /.* export-ignore | ||
| /tests export-ignore | ||
| /[Dd]ocker* export-ignore | ||
| /.* export-ignore | ||
| /phpunit.xml* export-ignore | ||
| /*.xml export-ignore | ||
| /*.xml.dist export-ignore | ||
| /phpstan.* export-ignore | ||
| /Makefile export-ignore | ||
| /rector.php export-ignore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| on: | ||
| push: | ||
| branches: | ||
| - '*' | ||
|
|
||
| name: Fix Code Style | ||
|
|
||
| jobs: | ||
| cs-fix: | ||
| permissions: | ||
| contents: write | ||
| uses: spiral/gh-actions/.github/workflows/cs-fix.yml@master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Mismatch in composer script invocation for test-cover
The Makefile’s
test-covertarget callscomposer phpunit:cover, but incomposer.jsonthe scripts are defined as"phpunit-cover"and"test-cover". Invokingcomposer phpunit:coverwill fail.composer test-cover.composer phpunit-cover.🏁 Script executed:
Length of output: 247
Incorrect Makefile composer script invocation
The
test-covertarget inMakefile(lines 31–32) calls:However, your
composer.jsondefines its scripts with dashes, not colons:•
"phpunit-cover"(standalone coverage)•
"test-cover"(composite coverage)Recommended fixes:
Please update the invocation accordingly.