improve logging

Author: robaho

build.gradle

@@ -117,7 +117,6 @@ task runSimpleFileServer(type: Test) {
     dependsOn testClasses
     doLast {
         def props = systemProperties
-        props.put("-Xshare","off")
         mkdir 'fileserver'
         javaexec {
             classpath sourceSets.test.runtimeClasspath

src/main/java/robaho/net/httpserver/ServerImpl.java

@@ -293,10 +293,10 @@ public void run() {
                         // we've hit max limit of current open connections, so we go
                         // ahead and close this connection without processing it
                         try {
+                            logger.log(Level.WARNING, "closing accepted connection due to too many connections");
                             s.close();
                         } catch (IOException ignore) {
                         }
-                        // move on to next selected key
                         continue;
                     }
 
@@ -334,8 +334,6 @@ public void run() {
         }
     }
 
-    static boolean debug = ServerConfig.debugEnabled();
-
     Logger getLogger() {
         return logger;
     }
@@ -656,11 +654,14 @@ public void run() {
 
             for (var c : allConnections) {
                 if (currentTime - c.lastActivityTime >= IDLE_INTERVAL && !c.inRequest) {
+                    logger.log(Level.WARNING, "closing idle connection");
                     closeConnection(c);
                     // idle.add(c);
                 } else if (c.noActivity && (currentTime - c.lastActivityTime >= NEWLY_ACCEPTED_CONN_IDLE_INTERVAL)) {
+                    logger.log(Level.WARNING, "closing newly accepted idle connection");
                     closeConnection(c);
                 } else if (MAX_REQ_TIME != -1 && c.inRequest && (currentTime - c.lastActivityTime >= MAX_REQ_TIME)) {
+                    logger.log(Level.WARNING, "closing connection due to request processing time");
                     closeConnection(c);
                 }
                 // TODO is MAX_RSP_TIME needed?

src/test/extras/SimpleFileServer.java

@@ -61,7 +61,6 @@ public static void main(String[] args) throws Exception {
         int port = Integer.parseInt(args[1]);
         String logfile = args[2];
         HttpServer server = HttpServer.create(new InetSocketAddress(port), 200);
-        server.setExecutor(Executors.newVirtualThreadPerTaskExecutor());
         HttpHandler h = new FileServerHandler(rootDir);
         HttpHandler h1 = new EchoHandler();
         HttpHandler h2 = new DevNullHandler();
@@ -75,7 +74,8 @@ public static void main(String[] args) throws Exception {
         HttpContext c2 = server.createContext("/devnull", h2);
         c2.getFilters().add(new LogFilter(new File(logfile)));
 
-        server.setExecutor(Executors.newCachedThreadPool());
+        server.setExecutor(Executors.newVirtualThreadPerTaskExecutor());
+        // server.setExecutor(Executors.newCachedThreadPool());
         server.start();
     }