Support kwargs same way as Robot Framework documentation states

[Hi-Fi]

In RF documentation (http://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#free-keyword-arguments-kwargs) it's mentioned that kwargs could be used in Java libraries by adding Map<String,Object> -kind of argument to method. In Javalib-core there's internal handling, that converts those kwargs to String[] causing it to be harder to parse those to usable form.

In javalib-core documentation there was no clear examples about the same kind of cases than in RF documentation, which would be nice to have, too.

[aronaks]

I would agree. Please add more examples for that fucntionality.

[Hi-Fi]

Implemented in #24, documentation needs to be updated after that's merged.

[shan-96]

#24 is merged to master but I am still able to reproduce issue #19

I think the argument collector should

1. number of args is one
2. check if arg is of type map
3. set this arg as kwarg parsing the object into Map<String,Object>

[shan-96]

Because if feel Free keyword arguments (**kwargs) are always going to be NULL in KeywordOverload.class for remote server because Java itself has no kwargs syntax, but keywords can have java.util.Map as the last argument to specify that they accept kwargs.

Which is conflicting in KeywordInvoker.class

[Hi-Fi]

@shan-96 could you please create test case showing the error? Kwargs are supported, but parsed before callung to keyword for named arguments. And there're tests also for cases that were encountered in own usage.

[Hi-Fi]

KeywordOverload shouldn't be used, but replace it with real default values. See e.g. MarketSquare/robotframework-seleniumlibrary-java@63b3542

[shan-96]

@shan-96 could you please create test case showing the error? Kwargs are supported, but parsed before callung to keyword for named arguments. And there're tests also for cases that were encountered in own usage.

@Hi-Fi I can create a Junit for ArgumentCollector.class and KeywordInvoker.class and push it to develop branch which can elaborate the example

[shan-96]

@Hi-Fi my bad, while debugging I was using .class files from release version 2.0.3

I have anyway written a test and pushed to develop. I'll open a PR for the same. Can we release 2.0.4 with fix #19 asap?

Thanks

[Hi-Fi]

So this is working, and change was only to include passing test?

This issue is still open because of documentation updates that are in wiki are missing.

[shan-96]

So this is working, and change was only to include passing test?

This issue is still open because of documentation updates that are in wiki are missing.

Yes, but I wont be able to test it end to end (fire a robot test case from tool like RIDE and validate java methods)

[Hi-Fi]

There are that kind of E2E tests already, and those can be added more. They're running with Maven.

But as said, there are plenty of tests for this functionality created, do have to check carefully if those new ones provide anything new.