From 3104a84d5e5d858c222a43e18f3e4a6f012ec758 Mon Sep 17 00:00:00 2001 From: ferdymercury Date: Mon, 27 Oct 2025 08:13:27 +0100 Subject: [PATCH 1/2] [hist] fix bug in margin not being symmetric 2nd delta was different since xmin was modified inbetween --- hist/hist/src/THLimitsFinder.cxx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hist/hist/src/THLimitsFinder.cxx b/hist/hist/src/THLimitsFinder.cxx index 700e1aa9534a4..a828f237b6b47 100644 --- a/hist/hist/src/THLimitsFinder.cxx +++ b/hist/hist/src/THLimitsFinder.cxx @@ -382,8 +382,9 @@ void THLimitsFinder::OptimizeLimits(Int_t nbins, Int_t &newbins, Double_t &xmin, xmin = -1; xmax = 1; } else { - xmin = std::min(binlow, xmin - 0.01 * (xmax - xmin)); - xmax = std::max(binhigh, xmax + 0.01 * (xmax - xmin)); + auto delta = 0.01 * (xmax - xmin); + xmin = std::min(binlow, xmin - delta); + xmax = std::max(binhigh, xmax + delta); } if (isInteger) { Long64_t ixmin = Long64_t(xmin); From a256bed42f8188c0c90d253fc5f13afbf63f2556 Mon Sep 17 00:00:00 2001 From: Stephan Hageboeck Date: Wed, 29 Oct 2025 14:28:43 +0100 Subject: [PATCH 2/2] Update from code review --- hist/hist/src/THLimitsFinder.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hist/hist/src/THLimitsFinder.cxx b/hist/hist/src/THLimitsFinder.cxx index a828f237b6b47..2a6a709bf12cd 100644 --- a/hist/hist/src/THLimitsFinder.cxx +++ b/hist/hist/src/THLimitsFinder.cxx @@ -382,7 +382,7 @@ void THLimitsFinder::OptimizeLimits(Int_t nbins, Int_t &newbins, Double_t &xmin, xmin = -1; xmax = 1; } else { - auto delta = 0.01 * (xmax - xmin); + const auto delta = 0.01 * (xmax - xmin); xmin = std::min(binlow, xmin - delta); xmax = std::max(binhigh, xmax + delta); }